Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1716533
| From | Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] video: fbdev: pxa3xx_gcu: fix error return code in pxa3xx_gcu_probe() |
| Date | 2017-08-21 16:20 +0200 |
| Message-ID | <ugVIB-5rU-5@gated-at.bofh.it> (permalink) |
| References | <ugVIB-5rU-7@gated-at.bofh.it> <ucl10-6pZ-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Tuesday, August 08, 2017 05:17:30 PM Gustavo A. R. Silva wrote: > platform_get_irq() returns an error code, but the pxa3xx_gcu driver > ignores it and always returns -ENODEV. This is not correct and, > prevents -EPROBE_DEFER from being propagated properly. > > Also, notice that platform_get_irq() no longer returns 0 on error: > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=e330b9a6bb35dc7097a4f02cb1ae7b6f96df92af > > Print and propagate the return value of platform_get_irq on failure. > > This issue was detected with the help of Coccinelle. > > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> Patch queued for 4.14, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
Re: [PATCH] video: fbdev: pxa3xx_gcu: fix error return code in pxa3xx_gcu_probe() Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2017-08-21 16:20 +0200
csiph-web