Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1716457

Re: [v2] macintosh: rack-meter: make of_device_ids const.

From Michael Ellerman <patch-notifications@ellerman.id.au>
Newsgroups linux.kernel
Subject Re: [v2] macintosh: rack-meter: make of_device_ids const.
Date 2017-08-21 15:40 +0200
Message-ID <ugV5T-4XE-7@gated-at.bofh.it> (permalink)
References <tTXJv-6Yt-15@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Mon, 2017-06-19 at 05:44:25 UTC, Arvind Yadav wrote:
> of_device_ids are not supposed to change at runtime. All functions
> working with of_device_ids provided by <linux/of.h> work with const
> of_device_ids. So mark the non-const structs as const.
> 
> File size before:
>    text	   data	    bss	    dec	    hex	filename
>     407	    576	      0	    983	    3d7	drivers/macintosh/rack-meter.o
> 
> File size after constify rackmeter_match.
>    text	   data	    bss	    dec	    hex	filename
>     807	    176	      0	    983	    3d7	drivers/macintosh/rack-meter.o
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>

Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/516fa8d0e19d854253460ea7692551

cheers

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

Re: [v2] macintosh: rack-meter: make of_device_ids const. Michael Ellerman <patch-notifications@ellerman.id.au> - 2017-08-21 15:40 +0200

csiph-web