Re: [PATCH 0/6] drivers: make device_attribute const

Path	csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Bhumika Goyal <bhumirks@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 0/6] drivers: make device_attribute const
Date	Mon, 21 Aug 2017 15:00:01 +0200
Message-ID	<ugUtb-4t7-13@gated-at.bofh.it> (permalink)
References	<ugTnr-3Rl-5@gated-at.bofh.it>
X-Original-To	Julia Lawall <julia.lawall@lip6.fr>, rjw@rjwysocki.net, Len Brown <lenb@kernel.org>, jbacik@fb.com, jikos@kernel.org, benjamin.tissoires@redhat.com, manish.chopra@cavium.com, rahul.verma@cavium.com, Dept-GELinuxNICDev@cavium.com, harish.patil@cavium.com, cascardo@holoscopio.com, don@syst.com.br, dvhart@infradead.org, Andy Shevchenko <andy@infradead.org>, sre@kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, nbd-general@lists.sourceforge.net, linux-input@vger.kernel.org, netdev@vger.kernel.org, Platform Driver <platform-driver-x86@vger.kernel.org>, linux-pm@vger.kernel.org
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=eF01YhAiH39M/hD/KLi/87FpGnppv+kAEMn2TN54I7Q=; b=CWfuPmmB8h+qwufI4RzbXFlgi155JXpi/2Hue5pSlZkFtFOdyBF/XAXWRQZGLgMxIY mew0JmkzqxLH/YFcxayQHgmQXjZ3sd5NDJtUVuWR8+VyQSFwIhEQhefNRvPrIEjvx8Dl pLNr3Z1PEI/d/aUvCAU4apJYw6E2b7NcbTKE4402XIN6TE1Dz2FMnkH+1FjyLFV4uCP/ GPYc4INXfwmAes4b4836anSzjJpqUsJKYe+NpoQNZpJkxkRu9msnkBsJHf8g7ZtGfNQa xbWF56ffIBgbJKdx75aq3qYrrDPrzdzAoGC8EWOTV7VcUgQ6zXuSLCnOfHpacAMt3RcY h5pg==
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=eF01YhAiH39M/hD/KLi/87FpGnppv+kAEMn2TN54I7Q=; b=mMMB7lEN+EElJkSaLNeKWddDqXnE2dU9pQ+yQmyUxLaa3QrdJGHV7bZcn4gC4bSO71 TFYHxSM2AHArkeVypdhf7l9Q85ShXPG9tdc+xBnrAR00oQdTYn7XbaRSYa9eW682mhvK fb1DyzURwyGodidESS+73yIqSYoi+L+pTC2LUQ7EaPmH0o8WCKpLcr/awEVAsfiVhxWt QjscXvmGo0u101lsWLEd+dLWD5oloCxY4DwUBcjFYqm3czeVdu4iepT8tqTdINfEjjZw +UJFcSFskTFexes48VSmOPSOqMVlKUtFjPkvuwvNGD1pCcSBNaThDgbllFgZqLQW85QX ExZg==
X-Gm-Message-State	AHYfb5gXQ8zIcP0uzVW4IAExSO4bPo+Ku97oWNeUxK3IhKbitqb0/JYb ViH6bBQ/Kg71dcP7/VPYHx+fiTD/fg==
X-Received	by 10.107.20.81 with SMTP id 78mr15117906iou.98.1503320115757; Mon, 21 Aug 2017 05:55:15 -0700 (PDT)
MIME-Version	1.0
Content-Type	text/plain; charset="UTF-8"
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	72
Organization	linux.* mail to news gateway
X-Original-Cc	Bhumika Goyal <bhumirks@gmail.com>
X-Original-Date	Mon, 21 Aug 2017 18:25:15 +0530
X-Original-Message-ID	<CAOH+1jFeD-V-hcnnmKN+9oEbYkf_FrCW74xrPTA3_WABmuH=AA@mail.gmail.com>
X-Original-References	<1503315792-14837-1-git-send-email-bhumirks@gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1716424

Show key headers only | View raw

On Mon, Aug 21, 2017 at 5:13 PM, Bhumika Goyal <bhumirks@gmail.com> wrote:
> Make these const. Done using Coccinelle.
>
> @match disable optional_qualifier@
> identifier s;
> @@
> static struct device_attribute s = {...};
>
> @ref@
> position p;
> identifier match.s;
> @@
> s@p
>
> @good1@
> identifier match.s;
> expression e1;
> position ref.p;
> @@
> device_remove_file(e1,&s@p,...)
>
> @good2@
> identifier match.s;
> expression e1;
> position ref.p;
> @@
> device_create_file(e1,&s@p,...)
>
>
> @bad depends on  !good1 && !good2@
> position ref.p;
> identifier match.s;
> @@
> s@p
>
> @depends on forall !bad disable optional_qualifier@
> identifier match.s;
> @@
> static
> + const
> struct device_attribute s;
>
> Bhumika Goyal (6):
>   ACPI: make device_attribute const
>   nbd: make device_attribute const
>   hid: make device_attribute const
>   qlogic:  make device_attribute const
>   platform/x86: make device_attribute const
>   power: supply: make device_attribute const
>

Hello all,

The patches are all independent, so please take what seems relevant.

Thanks,
Bhumika

>  drivers/acpi/battery.c                               | 2 +-
>  drivers/acpi/sbs.c                                   | 2 +-
>  drivers/block/nbd.c                                  | 2 +-
>  drivers/hid/hid-core.c                               | 2 +-
>  drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c | 4 ++--
>  drivers/net/ethernet/qlogic/qlcnic/qlcnic_sysfs.c    | 6 +++---
>  drivers/platform/x86/classmate-laptop.c              | 6 +++---
>  drivers/platform/x86/intel-rst.c                     | 4 ++--
>  drivers/power/supply/olpc_battery.c                  | 2 +-
>  9 files changed, 15 insertions(+), 15 deletions(-)
>
> --
> 1.9.1
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/6] drivers:  make device_attribute const Bhumika Goyal <bhumirks@gmail.com> - 2017-08-21 13:50 +0200
  [PATCH 2/6] nbd: make device_attribute const Bhumika Goyal <bhumirks@gmail.com> - 2017-08-21 13:50 +0200
  [PATCH 3/6] hid: make device_attribute const Bhumika Goyal <bhumirks@gmail.com> - 2017-08-21 13:50 +0200
  [PATCH 4/6] qlogic:  make device_attribute const Bhumika Goyal <bhumirks@gmail.com> - 2017-08-21 13:50 +0200
    Re: [PATCH 4/6] qlogic: make device_attribute const David Miller <davem@davemloft.net> - 2017-08-21 19:30 +0200
      Re: [PATCH 4/6] qlogic: make device_attribute const Bhumika Goyal <bhumirks@gmail.com> - 2017-08-21 19:30 +0200
  Re: [PATCH 0/6] drivers: make device_attribute const "Rafael J. Wysocki" <rafael@kernel.org> - 2017-08-21 14:30 +0200
    Re: [PATCH 0/6] drivers: make device_attribute const Bhumika Goyal <bhumirks@gmail.com> - 2017-08-21 15:00 +0200
  Re: [PATCH 0/6] drivers: make device_attribute const Bhumika Goyal <bhumirks@gmail.com> - 2017-08-21 15:00 +0200

csiph-web