Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1716434
| From | Adrian Hunter <adrian.hunter@intel.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] mmc: tegra: suppress errors when probe is deferred |
| Date | 2017-08-21 15:20 +0200 |
| Message-ID | <ugUMx-4R2-5@gated-at.bofh.it> (permalink) |
| References | <ufrCW-4m1-33@gated-at.bofh.it> |
| Organization | Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki |
On 17/08/17 14:52, Timo Alho wrote:
> Don't print error message when clk_get() returns -EPROBE_DEFER. On
> recent Tegra chips (t186 onwards), the clocks are provided by
> auxiliary microprocessor (bpmp) and until the driver for it is probed
> clocks are not available.
>
> While at it, change the real error message more meaningful.
>
> Signed-off-by: Timo Alho <talho@nvidia.com>
One comment below, nevertheless:
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
> drivers/mmc/host/sdhci-tegra.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-tegra.c b/drivers/mmc/host/sdhci-tegra.c
> index f668a6f..cdde9ff 100644
> --- a/drivers/mmc/host/sdhci-tegra.c
> +++ b/drivers/mmc/host/sdhci-tegra.c
> @@ -501,8 +501,10 @@ static int sdhci_tegra_probe(struct platform_device *pdev)
>
> clk = devm_clk_get(mmc_dev(host->mmc), NULL);
> if (IS_ERR(clk)) {
> - dev_err(mmc_dev(host->mmc), "clk err\n");
> rc = PTR_ERR(clk);
> + if (rc != -EPROBE_DEFER)
> + dev_err(&pdev->dev,
Looks a bit weird sometimes using mmc_dev(host->mmc) and sometimes &pdev->dev.
> + "failed to get controller clock: %d\n", rc);
> goto err_clk_get;
> }
> clk_prepare_enable(clk);
>
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] mmc: tegra: suppress errors when probe is deferred Timo Alho <talho@nvidia.com> - 2017-08-17 14:00 +0200 Re: [PATCH] mmc: tegra: suppress errors when probe is deferred Adrian Hunter <adrian.hunter@intel.com> - 2017-08-21 15:20 +0200 Re: [PATCH] mmc: tegra: suppress errors when probe is deferred Ulf Hansson <ulf.hansson@linaro.org> - 2017-08-22 11:30 +0200
csiph-web