Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1716353
| From | wlf <wulf@rock-chips.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2 1/2] arm64: dts: rockchip: add usb3 controller node for RK3328 SoCs |
| Date | 2017-08-21 13:40 +0200 |
| Message-ID | <ugTdM-3NW-29@gated-at.bofh.it> (permalink) |
| References | <ufnSG-1MZ-19@gated-at.bofh.it> <ufnSG-1MZ-35@gated-at.bofh.it> <ufLLk-1yQ-17@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Dear Heiko, 在 2017年08月18日 17:24, Heiko Stuebner 写道: > Hi William, > > Am Donnerstag, 17. August 2017, 15:54:49 CEST schrieb William Wu: >> RK3328 has one USB 3.0 OTG controller which uses DWC_USB3 >> core's general architecture. It can act as static xHCI host >> controller, static device controller, USB 3.0/2.0 OTG basing >> on ID of USB3.0 PHY. >> >> Signed-off-by: William Wu <william.wu@rock-chips.com> >> --- >> Changes in v2: >> - Modify the dwc3 quirk "snps,tx-ipgap-linecheck-dis-quirk" to >> "snps,dis-tx-ipgap-linecheck-quirk" >> >> .../devicetree/bindings/usb/rockchip,dwc3.txt | 4 +++- >> arch/arm64/boot/dts/rockchip/rk3328.dtsi | 27 ++++++++++++++++++++++ >> 2 files changed, 30 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/usb/rockchip,dwc3.txt b/Documentation/devicetree/bindings/usb/rockchip,dwc3.txt >> index 0536a93..d6b2e47 100644 >> --- a/Documentation/devicetree/bindings/usb/rockchip,dwc3.txt >> +++ b/Documentation/devicetree/bindings/usb/rockchip,dwc3.txt >> @@ -1,7 +1,9 @@ >> Rockchip SuperSpeed DWC3 USB SoC controller >> >> Required properties: >> -- compatible: should contain "rockchip,rk3399-dwc3" for rk3399 SoC >> +- compatible: should be one of the following: >> + - "rockchip,rk3399-dwc3": for rk3399 SoC >> + - "rockchip,rk3328-dwc3", "rockchip,rk3399-dwc3": for rk3328 SoC >> - clocks: A list of phandle + clock-specifier pairs for the >> clocks listed in clock-names >> - clock-names: Should contain the following: > This probably shouldn't be part of the patch adding the dts node, but > instead should be a separate patch and should either go through some > usb tree or at least get an Ack from usb maintainers (Felipe Balbi and/or > Greg Kroah Hartman), so you should definitly include them into your > recipient list. Thanks for your suggestion. I will submit two patches separately, and add usb maintainers in the recipient list. > > > Heiko > > > > -- 吴良峰 William.Wu 福建省福州市铜盘路软件大道89号软件园A区21号楼 No.21 Building, A District, No.89,software Boulevard Fuzhou,Fujian, PRC 手机: 13685012275 座机: 0591-83991906-8520 邮件:wulf@rock-chips.com
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH v2 1/2] arm64: dts: rockchip: add usb3 controller node for RK3328 SoCs William Wu <william.wu@rock-chips.com> - 2017-08-17 10:00 +0200
Re: [PATCH v2 1/2] arm64: dts: rockchip: add usb3 controller node for RK3328 SoCs Heiko Stuebner <heiko@sntech.de> - 2017-08-18 11:30 +0200
Re: [PATCH v2 1/2] arm64: dts: rockchip: add usb3 controller node for RK3328 SoCs wlf <wulf@rock-chips.com> - 2017-08-21 13:40 +0200
csiph-web