Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1716214

Re: [PATCH] kbuild: use $(abspath ...) instead of $(shell cd ... && /bin/pwd)

Show all headers | View raw

2017-08-21 17:49 GMT+09:00 Thierry Reding <treding@nvidia.com>:
> On Sun, Aug 20, 2017 at 03:04:11PM +0900, Masahiro Yamada wrote:
>> Kbuild conventionally uses $(shell cd ... && /bin/pwd) idiom to get
>> the absolute path of the directory because GNU Make 3.80, the minimal
>> supported version at that time, did not support $(abspath ...) or
>> $(realpath ...).
>>
>> Commit 37d69ee30808 ("docs: bump minimal GNU Make version to 3.81")
>> dropped the GNU Make 3.80 support, so we are now allowed to use those
>> make-builtin helpers.
>>
>> This conversion will provide better portability without relying on
>> the pwd command or its location /bin/pwd.
>>
>> I am intentionally using $(realpath ...) instead $(abspath ...) in
>> some places.  The difference between the two is $(realpath ...)
>> returns an empty string if the given path does not exist.  It is
>> convenient in places where we need to error-out if the makefile fails
>> to create an output directory.
>>
>> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
>> ---
>>
>>  Makefile                       | 12 ++++++------
>>  scripts/gdb/linux/Makefile     |  2 +-
>>  tools/power/cpupower/Makefile  |  2 +-
>>  tools/scripts/Makefile.include |  6 +++---
>>  4 files changed, 11 insertions(+), 11 deletions(-)
>
> This looks very similar to a patch I had written a long time ago:
>
> Acked-by: Thierry Reding <treding@nvidia.com>


Yup.

Three month ago, I sent a reminder to you,
but I did not get a response.

https://lkml.org/lkml/2017/5/18/1370




This time, Bjorn sent a patch to replace /bin/pwd with pwd.

I asked him to use $(abspath ...) / $(realpath ...),
but he did not like to do it.

https://patchwork.kernel.org/patch/9859591/


So, I am doing it by myself.



-- 
Best Regards
Masahiro Yamada

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] kbuild: use $(abspath ...) instead of $(shell cd ... && /bin/pwd) Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-08-20 08:10 +0200
  Re: [PATCH] kbuild: use $(abspath ...) instead of $(shell cd ... &&  /bin/pwd) Thierry Reding <treding@nvidia.com> - 2017-08-21 11:00 +0200
    Re: [PATCH] kbuild: use $(abspath ...) instead of $(shell cd ... && /bin/pwd) Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-08-21 11:10 +0200

csiph-web