Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1716094

Re: [PATCH v3 4/5] perf annotate browser: Support --show-nr-samples option

Show all headers | View raw

On 08/18/2017 11:17 PM, Arnaldo Carvalho de Melo wrote:
> Em Fri, Aug 18, 2017 at 05:47:03PM +0900, Taeung Song escreveu:
>> Cc: Namhyung Kim <namhyung@kernel.org>
>> Cc: Jiri Olsa <jolsa@redhat.com>
>> Signed-off-by: Taeung Song <treeze.taeung@gmail.com>
> 
> Ok, now that check for !--stdio is lifted and replaced with:
> 
> -       if (symbol_conf.show_nr_samples && !annotate.use_stdio) {
> -               pr_err("--show-nr-samples is only available in --stdio mode at this time\n");
> +       if (symbol_conf.show_nr_samples && annotate.use_gtk) {
> +               pr_err("--show-nr-samples is not available in --gtk mode at this time\n");
>                  return ret;
>          }
> 
> - Arnaldo
> 

I got it :)

Thanks,
Taeung

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 4/5] perf annotate browser: Support --show-nr-samples option Taeung Song <treeze.taeung@gmail.com> - 2017-08-18 10:50 +0200
  Re: [PATCH v3 4/5] perf annotate browser: Support --show-nr-samples  option Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-08-18 16:20 +0200
    Re: [PATCH v3 4/5] perf annotate browser: Support --show-nr-samples  option Taeung Song <treeze.taeung@gmail.com> - 2017-08-21 07:40 +0200
  [tip:perf/core] perf annotate browser: Support --show-nr-samples  option tip-bot for Taeung Song <tipbot@zytor.com> - 2017-08-22 12:30 +0200

csiph-web