Re: [PATCH 3.16 084/134] usb: misc: legousbtower: Fix buffers on stack

From	Maksim Salau <maksim.salau@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3.16 084/134] usb: misc: legousbtower: Fix buffers on stack
Date	2017-08-19 08:30 +0200
Message-ID	<ug5qF-6cp-5@gated-at.bofh.it> (permalink)
References	<ufPlT-4d0-3@gated-at.bofh.it> <ufPFh-4ln-49@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, 18 Aug 2017 14:13:20 +0100
Ben Hutchings <ben@decadent.org.uk> wrote:

> 3.16.47-rc1 review patch.  If anyone has any objections, please let me know.
> 
> ------------------
> 
> From: Maksim Salau <maksim.salau@gmail.com>
> 
> commit 942a48730faf149ccbf3e12ac718aee120bb3529 upstream.
> 
> Allocate buffers on HEAP instead of STACK for local structures
> that are to be received using usb_control_msg().

Hi Ben,

The change has a memory leak, which is fixed by the commit
0bd193d62b4270a2a7a09da43ad1034c7ca5b3d3
If the commit is not in your queue, please add it.

Thanks,
Maksim.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 3.16 084/134] usb: misc: legousbtower: Fix buffers on stack Ben Hutchings <ben@decadent.org.uk> - 2017-08-18 15:40 +0200
  Re: [PATCH 3.16 084/134] usb: misc: legousbtower: Fix buffers on  stack Maksim Salau <maksim.salau@gmail.com> - 2017-08-19 08:30 +0200

csiph-web