Re: [PATCH 2/2] perf, tools: Avoid segfault on alias parse error

From	Andi Kleen <ak@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] perf, tools: Avoid segfault on alias parse error
Date	2017-08-17 19:10 +0200
Message-ID	<ufwsW-7Rh-3@gated-at.bofh.it> (permalink)
References	<ufeFH-4jg-5@gated-at.bofh.it> <ufeFH-4jg-3@gated-at.bofh.it> <ufuUa-6IK-7@gated-at.bofh.it> <ufv3Q-6Mn-19@gated-at.bofh.it> <ufvQe-7mK-25@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Aug 17, 2017 at 01:25:39PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Thu, Aug 17, 2017 at 08:34:22AM -0700, Andi Kleen escreveu:
> > > Humm, but don't we have that checked?
> > 
> > At least not in the case of the segfault below.
> 
> Again:
> 
> tools/perf/util/parse-events.c
> 
> 2523 void parse_events_evlist_error(struct parse_events_evlist *data,
> 2524                                int idx, const char *str)
> 2525 {
> 2526         struct parse_events_error *err = data->error;
> 2527 
> 2528         if (!err)
> 2529                 return;
> 2530         err->idx = idx;
> 2531         err->str = strdup(str);
> 2532         WARN_ONCE(!err->str, "WARNING: failed to allocate error string");
> 2533 }
> 
> data->error _is_ being checked for NULL, and the hunk you added would

In the crash, data->error is not NULL, it's random stack contents
because the data types for the data pointer do not match
(parse_events_evlist vs parse_events_terms)

-Andi

Thread

[PATCH 2/2] perf, tools: Avoid segfault on alias parse error Andi Kleen <andi@firstfloor.org> - 2017-08-17 00:10 +0200
  Re: [PATCH 2/2] perf, tools: Avoid segfault on alias parse error Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-08-17 17:30 +0200
    Re: [PATCH 2/2] perf, tools: Avoid segfault on alias parse error Andi Kleen <andi@firstfloor.org> - 2017-08-17 17:40 +0200
      Re: [PATCH 2/2] perf, tools: Avoid segfault on alias parse error Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-08-17 18:30 +0200
        Re: [PATCH 2/2] perf, tools: Avoid segfault on alias parse error Andi Kleen <ak@linux.intel.com> - 2017-08-17 19:10 +0200
    Re: [PATCH 2/2] perf, tools: Avoid segfault on alias parse error Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-08-17 18:50 +0200
      Re: [PATCH 2/2] perf, tools: Avoid segfault on alias parse error Andi Kleen <ak@linux.intel.com> - 2017-08-17 19:10 +0200
        Re: [PATCH 2/2] perf, tools: Avoid segfault on alias parse error Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-08-17 19:30 +0200
          Re: [PATCH 2/2] perf, tools: Avoid segfault on alias parse error Jiri Olsa <jolsa@redhat.com> - 2017-08-22 09:30 +0200

csiph-web