Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1714242

Re: [patch-rt] hotplug, hrtimer: Migrate expired/deferred timers during cpu offline

From Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Newsgroups linux.kernel
Subject Re: [patch-rt] hotplug, hrtimer: Migrate expired/deferred timers during cpu offline
Date 2017-08-17 19:20 +0200
Message-ID <ufwCE-7Vp-67@gated-at.bofh.it> (permalink)
References (5 earlier) <uc9Cx-6yS-3@gated-at.bofh.it> <udd1o-LV-15@gated-at.bofh.it> <uddkK-17M-23@gated-at.bofh.it> <ueiBI-1HF-7@gated-at.bofh.it> <ufwjg-7yn-7@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 2017-08-17 18:50:42 [+0200], To Mike Galbraith wrote:
> __remove_hrtimer() shouldn't be required because it has been done
> already. It should be enough to just list_splice() one list to the
> other and raise the softirq afterwards.

Mike, can you check this please:

diff --git a/kernel/time/hrtimer.c b/kernel/time/hrtimer.c
index 55839ff2bba6..4b9264e0d363 100644
--- a/kernel/time/hrtimer.c
+++ b/kernel/time/hrtimer.c
@@ -1802,6 +1802,11 @@ static void migrate_hrtimer_list(struct hrtimer_clock_base *old_base,
 		 */
 		enqueue_hrtimer(timer, new_base);
 	}
+#ifdef CONFIG_PREEMPT_RT_BASE
+	list_splice_tail(&old_base->expired, &new_base->expired);
+	if (!list_empty(&new_base->expired))
+		raise_softirq_irqoff(HRTIMER_SOFTIRQ);
+#endif
 }
 
 int hrtimers_dead_cpu(unsigned int scpu)
-- 
2.13.2

Sebastian

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

Re: [patch-rt] hotplug, hrtimer: Migrate expired/deferred timers  during cpu offline Mike Galbraith <efault@gmx.de> - 2017-08-14 10:10 +0200
  Re: [patch-rt] hotplug, hrtimer: Migrate expired/deferred timers  during cpu offline Sebastian Andrzej Siewior <bigeasy@linutronix.de> - 2017-08-17 19:00 +0200
    Re: [patch-rt] hotplug, hrtimer: Migrate expired/deferred timers  during cpu offline Sebastian Andrzej Siewior <bigeasy@linutronix.de> - 2017-08-17 19:20 +0200
      Re: [patch-rt] hotplug, hrtimer: Migrate expired/deferred timers  during cpu offline Mike Galbraith <efault@gmx.de> - 2017-08-17 19:30 +0200
        Re: [patch-rt] hotplug, hrtimer: Migrate expired/deferred timers  during cpu offline Mike Galbraith <efault@gmx.de> - 2017-08-17 19:40 +0200
      Re: [patch-rt] hotplug, hrtimer: Migrate expired/deferred timers  during cpu offline Mike Galbraith <efault@gmx.de> - 2017-08-17 20:50 +0200

csiph-web