Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1714191

Re: [PATCH][i2c-next] i2c-cht-wc: make cht_wc_i2c_adap_driver static

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Wed, Aug 16, 2017 at 10:16:59AM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> The structure cht_wc_i2c_adap_driver is local to the source
> and does not need to be in global scope, so make it static.
> 
> Cleans up sparse warning:
> symbol 'cht_wc_i2c_adap_driver' was not declared. Should it be static?
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

CCing Hans to ask him if he maybe wants to create a MAINTAINERS entry
for this driver, so he'll get CCed for such patches? :)

> ---
>  drivers/i2c/busses/i2c-cht-wc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/i2c/busses/i2c-cht-wc.c b/drivers/i2c/busses/i2c-cht-wc.c
> index fe5caf70c7fe..01c94c918d4c 100644
> --- a/drivers/i2c/busses/i2c-cht-wc.c
> +++ b/drivers/i2c/busses/i2c-cht-wc.c
> @@ -322,7 +322,7 @@ static struct platform_device_id cht_wc_i2c_adap_id_table[] = {
>  };
>  MODULE_DEVICE_TABLE(platform, cht_wc_i2c_adap_id_table);
>  
> -struct platform_driver cht_wc_i2c_adap_driver = {
> +static struct platform_driver cht_wc_i2c_adap_driver = {
>  	.probe = cht_wc_i2c_adap_i2c_probe,
>  	.remove = cht_wc_i2c_adap_i2c_remove,
>  	.driver = {
> -- 
> 2.11.0
> 

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH][i2c-next] i2c-cht-wc: make cht_wc_i2c_adap_driver static Colin King <colin.king@canonical.com> - 2017-08-16 11:20 +0200
  Re: [PATCH][i2c-next] i2c-cht-wc: make cht_wc_i2c_adap_driver static Wolfram Sang <wsa@the-dreams.de> - 2017-08-17 18:40 +0200

csiph-web