Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1713972

Re: [PATCH V4 net-next 21/21] net-next/hinic: Add select_queue and netpoll

Show all headers | View raw

Hi David,

Fixed in V6.
In V5 patch-set there was a problem in cover-letter msg-id.

Thanks,
Aviad

On 8/16/2017 9:47 PM, David Miller wrote:
> From: Aviad Krawczyk <aviad.krawczyk@huawei.com>
> Date: Wed, 16 Aug 2017 20:03:06 +0800
> 
>> +static u16 hinic_select_queue(struct net_device *netdev, struct sk_buff *skb,
>> +			      void *accel_priv,
>> +			      select_queue_fallback_t fallback)
>> +{
>> +	u16 qid;
>> +
>> +	if (skb_rx_queue_recorded(skb))
>> +		qid = skb_get_rx_queue(skb);
>> +	else
>> +		qid = fallback(netdev, skb);
>> +
>> +	return qid;
>> +}
> 
> This is a NOP, do not implement this function unless you absolutely need to
> do something custom in your driver, and you do not.
> 
> .
> 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH V4 net-next 00/21] Huawei HiNIC Ethernet Driver Aviad Krawczyk <aviad.krawczyk@huawei.com> - 2017-08-16 14:00 +0200
  [PATCH V4 net-next 13/21] net-next/hinic: Set qp context Aviad Krawczyk <aviad.krawczyk@huawei.com> - 2017-08-16 14:00 +0200
  [PATCH V4 net-next 08/21] net-next/hinic: Add port management commands Aviad Krawczyk <aviad.krawczyk@huawei.com> - 2017-08-16 14:00 +0200
  [PATCH V4 net-next 04/21] net-next/hinic: Initialize api cmd hw Aviad Krawczyk <aviad.krawczyk@huawei.com> - 2017-08-16 14:00 +0200
  [PATCH V4 net-next 06/21] net-next/hinic: Add api cmd commands Aviad Krawczyk <aviad.krawczyk@huawei.com> - 2017-08-16 14:00 +0200
  [PATCH V4 net-next 02/21] net-next/hinic: Initialize hw device components Aviad Krawczyk <aviad.krawczyk@huawei.com> - 2017-08-16 14:00 +0200
  [PATCH V4 net-next 05/21] net-next/hinic: Add management messages Aviad Krawczyk <aviad.krawczyk@huawei.com> - 2017-08-16 14:00 +0200
  [PATCH V4 net-next 15/21] net-next/hinic: Add ceqs Aviad Krawczyk <aviad.krawczyk@huawei.com> - 2017-08-16 14:10 +0200
  [PATCH V4 net-next 19/21] net-next/hinic: Add Tx operation Aviad Krawczyk <aviad.krawczyk@huawei.com> - 2017-08-16 14:10 +0200
  [PATCH V4 net-next 17/21] net-next/hinic: Add cmdq completion handler Aviad Krawczyk <aviad.krawczyk@huawei.com> - 2017-08-16 14:10 +0200
  [PATCH V4 net-next 14/21] net-next/hinic: Initialize cmdq Aviad Krawczyk <aviad.krawczyk@huawei.com> - 2017-08-16 14:10 +0200
  [PATCH V4 net-next 16/21] net-next/hinic: Add cmdq commands Aviad Krawczyk <aviad.krawczyk@huawei.com> - 2017-08-16 14:10 +0200
  [PATCH V4 net-next 21/21] net-next/hinic: Add select_queue and netpoll Aviad Krawczyk <aviad.krawczyk@huawei.com> - 2017-08-16 14:10 +0200
    Re: [PATCH V4 net-next 21/21] net-next/hinic: Add select_queue and  netpoll David Miller <davem@davemloft.net> - 2017-08-16 20:50 +0200
      Re: [PATCH V4 net-next 21/21] net-next/hinic: Add select_queue and  netpoll Aviad Krawczyk <aviad.krawczyk@huawei.com> - 2017-08-17 14:50 +0200
  [PATCH V4 net-next 20/21] net-next/hinic: Add ethtool and stats Aviad Krawczyk <aviad.krawczyk@huawei.com> - 2017-08-16 14:10 +0200

csiph-web