Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1713808

Re: [PATCH v3] acpi: apei: fix the wrongly iterate generic error status block

Show all headers | View raw

Borislav,
  thanks for the review,

On 2017/8/17 17:25, Borislav Petkov wrote:
> On Wed, Aug 16, 2017 at 04:14:50PM +0800, Dongjiu Geng wrote:
>> The revision 0x300 generic error data entry is different
>> from the old version, but currently iterating through the
>> GHES estatus blocks does not take into account this difference.
>> This will lead to failure to get the right data entry if GHES
>> has revision 0x300 error data entry.
>>
>> Update the GHES estatus iteration to properly increment using
> 			  iteration macro
> 
>> acpi_hest_get_next, and correct the iteration termination condition
> Please end function names with parentheses.
> 
>> because the status block data length only includes error data length.
> <---- newline here.
> 
>> Clear the CPER estatus printing iteration logic to use same macro.
> s/Clear ... /Convert ... to the same macro./
> 
>> Signed-off-by: Dongjiu Geng <gengdongjiu@huawei.com>
>> CC: Tyler Baicar <tbaicar@codeaurora.org>
>> ---
>>  drivers/acpi/apei/apei-internal.h |  5 -----
>>  drivers/firmware/efi/cper.c       | 12 ++----------
>>  include/acpi/ghes.h               |  5 +++++
>>  3 files changed, 7 insertions(+), 15 deletions(-)
> With those addressed you can add:
  Ok, I will add.

> 
> Reviewed-by: Borislav Petkov <bp@suse.de>
> 
> -- 

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v3] acpi: apei: fix the wrongly iterate generic error status block Dongjiu Geng <gengdongjiu@huawei.com> - 2017-08-16 10:00 +0200
  Re: [PATCH v3] acpi: apei: fix the wrongly iterate generic error  status block "Baicar, Tyler" <tbaicar@codeaurora.org> - 2017-08-16 16:00 +0200
    Re: [PATCH v3] acpi: apei: fix the wrongly iterate generic error  status block gengdongjiu <gengdongjiu@huawei.com> - 2017-08-17 05:20 +0200
  Re: [PATCH v3] acpi: apei: fix the wrongly iterate generic error  status block Borislav Petkov <bp@suse.de> - 2017-08-17 11:40 +0200
    Re: [PATCH v3] acpi: apei: fix the wrongly iterate generic error  status block gengdongjiu <gengdongjiu@huawei.com> - 2017-08-17 12:50 +0200

csiph-web