[PATCH] drm/nouveau: remove redundant null check on array mstm->msto

From	Colin King <colin.king@canonical.com>
Newsgroups	linux.kernel
Subject	[PATCH] drm/nouveau: remove redundant null check on array mstm->msto
Date	2017-08-17 12:40 +0200
Message-ID	<ufqnv-3zF-17@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Colin Ian King <colin.king@canonical.com>

The check to see if mstm->msto is null is redundant because it is
an array and hence can never be null.  Remove the redundant check.

Detected by CoverityScan, CID#1375915 ("Array compared against 0")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/gpu/drm/nouveau/nv50_display.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/nouveau/nv50_display.c b/drivers/gpu/drm/nouveau/nv50_display.c
index f7b4326a4641..51e9081b95a0 100644
--- a/drivers/gpu/drm/nouveau/nv50_display.c
+++ b/drivers/gpu/drm/nouveau/nv50_display.c
@@ -3141,7 +3141,7 @@ nv50_mstc_new(struct nv50_mstm *mstm, struct drm_dp_mst_port *port,
 	mstc->connector.funcs->reset(&mstc->connector);
 	nouveau_conn_attach_properties(&mstc->connector);
 
-	for (i = 0; i < ARRAY_SIZE(mstm->msto) && mstm->msto; i++)
+	for (i = 0; i < ARRAY_SIZE(mstm->msto); i++)
 		drm_mode_connector_attach_encoder(&mstc->connector, &mstm->msto[i]->encoder);
 
 	drm_object_attach_property(&mstc->connector.base, dev->mode_config.path_property, 0);
-- 
2.11.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] drm/nouveau: remove redundant null check on array mstm->msto Colin King <colin.king@canonical.com> - 2017-08-17 12:40 +0200
  Re: [Nouveau] [PATCH] drm/nouveau: remove redundant null check on  array mstm->msto Emil Velikov <emil.l.velikov@gmail.com> - 2017-08-17 14:30 +0200
    Re: [Nouveau] [PATCH] drm/nouveau: remove redundant null check on  array mstm->msto Colin Ian King <colin.king@canonical.com> - 2017-08-17 15:10 +0200

csiph-web