Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1713722

Re: [PATCH v3 3/5] reset: stm32: use the reset-simple driver

Show all headers | View raw

Hi,

On 16/08/17 21:55, Alexandru Gagniuc wrote:
> 
> 
> On 08/16/2017 01:52 PM, Andreas Färber wrote:
>> Am 16.08.2017 um 22:50 schrieb Alexandru Gagniuc:
>>> On 08/16/2017 02:46 AM, Philipp Zabel wrote:
>>>> The reset-simple driver can be used without changes.
>>>>
>>>> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
>>>
>>> Reviewed-by: Alexandru Gagniuc <alex.g@adaptrum.com>
>>>
>>>> ---
>>>>  drivers/reset/Kconfig        |  11 ++---
>>>>  drivers/reset/Makefile       |   1 -
>>>>  drivers/reset/reset-simple.c |   1 +
>>>>  drivers/reset/reset-stm32.c  | 108
>>>> -------------------------------------------
>>>>  4 files changed, 4 insertions(+), 117 deletions(-)
>>>>  delete mode 100644 drivers/reset/reset-stm32.c
>>>>
>>>> diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
>>>> index 78a8f6057985b..29f4487c290fc 100644
>>>> --- a/drivers/reset/Kconfig
>>>> +++ b/drivers/reset/Kconfig
>>>> @@ -70,19 +70,14 @@ config RESET_PISTACHIO
>>>>
>>>>  config RESET_SIMPLE
>>>>      bool "Simple Reset Controller Driver" if COMPILE_TEST
>>>> -    default ARCH_SOCFPGA || ARCH_SUNXI
>>>> +    default ARCH_SOCFPGA || ARCH_STM32 || ARCH_SUNXI
>>>
>>> If this series gets respun, could you please look into removing the
>>> ARCH_ dependency here?
>>
>> Why?
> 
> Because the driver has to keep track of all its users, which is a
> layering violation.

"keep track of all its users": not necessarily, this is mostly for
convenience reasons to get automatic coverage for those SoCs without
changing various defconfigs - or distribution .configs, for that matter.
Especially the latter may prove to be nasty and introduce regressions.

But I see that this list may grow big and this is a bit beyond the scope
of the otherwise neat "default ARCH_xxx" trick.

So given the generic nature of this driver, can't we make this simply:
"default ARM || ARM64"
That would enable it everywhere automatically, but people can still
disable this if they know what they do.

Alternatively for ARM64 this is actually a candidate for the (one and
only) defconfig.

Cheers,
Andre.

>> It's not a dependency, just the default. Doing it here decouples it
>> from having to do Kconfig changes in the arm-soc tree as well.
> 
> Doing it here allows this list to grow without bounds.
> 
>> Regards,
>> Andreas
>>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 0/5] Unify simple reset drivers Philipp Zabel <p.zabel@pengutronix.de> - 2017-08-16 11:50 +0200
  [PATCH v3 4/5] reset: zx2967: use the reset-simple driver Philipp Zabel <p.zabel@pengutronix.de> - 2017-08-16 11:50 +0200
  [PATCH v3 1/5] reset: add reset-simple to unify socfpga, stm32, sunxi, and zx2967 Philipp Zabel <p.zabel@pengutronix.de> - 2017-08-16 11:50 +0200
    Re: [PATCH v3 1/5] reset: add reset-simple to unify socfpga, stm32,  sunxi, and zx2967 Andre Przywara <andre.przywara@arm.com> - 2017-08-16 13:40 +0200
      Re: [PATCH v3 1/5] reset: add reset-simple to unify socfpga, stm32,  sunxi, and zx2967 Andreas Färber <afaerber@suse.de> - 2017-08-16 14:20 +0200
        Re: [PATCH v3 1/5] reset: add reset-simple to unify socfpga, stm32,  sunxi, and zx2967 Andre Przywara <andre.przywara@arm.com> - 2017-08-16 17:20 +0200
        Re: [PATCH v3 1/5] reset: add reset-simple to unify socfpga, stm32,  sunxi, and zx2967 Philipp Zabel <p.zabel@pengutronix.de> - 2017-08-16 17:20 +0200
          Re: [PATCH v3 1/5] reset: add reset-simple to unify socfpga, stm32,  sunxi, and zx2967 Andre Przywara <andre.przywara@arm.com> - 2017-08-16 18:50 +0200
          Re: [PATCH v3 1/5] reset: add reset-simple to unify socfpga, stm32,  sunxi, and zx2967 Andreas Färber <afaerber@suse.de> - 2017-08-16 18:50 +0200
  [PATCH v3 2/5] reset: socfpga: use the reset-simple driver Philipp Zabel <p.zabel@pengutronix.de> - 2017-08-16 11:50 +0200
    Re: [PATCH v3 2/5] reset: socfpga: use the reset-simple driver Philipp Zabel <p.zabel@pengutronix.de> - 2017-08-21 10:50 +0200
  [PATCH v3 3/5] reset: stm32: use the reset-simple driver Philipp Zabel <p.zabel@pengutronix.de> - 2017-08-16 11:50 +0200
    Re: [PATCH v3 3/5] reset: stm32: use the reset-simple driver Andreas Färber <afaerber@suse.de> - 2017-08-16 15:00 +0200
    Re: [PATCH v3 3/5] reset: stm32: use the reset-simple driver Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com> - 2017-08-16 15:00 +0200
      Re: [PATCH v3 3/5] reset: stm32: use the reset-simple driver Andre Przywara <andre.przywara@arm.com> - 2017-08-16 15:10 +0200
    Re: [PATCH v3 3/5] reset: stm32: use the reset-simple driver Andreas Färber <afaerber@suse.de> - 2017-08-16 23:00 +0200
      Re: [PATCH v3 3/5] reset: stm32: use the reset-simple driver Andre Przywara <andre.przywara@arm.com> - 2017-08-17 11:30 +0200
        Re: [PATCH v3 3/5] reset: stm32: use the reset-simple driver Philipp Zabel <p.zabel@pengutronix.de> - 2017-08-21 10:40 +0200
  [PATCH v3 5/5] reset: simple: read back to make sure changes are applied Philipp Zabel <p.zabel@pengutronix.de> - 2017-08-16 11:50 +0200
    Re: [PATCH v3 5/5] reset: simple: read back to make sure changes  are applied Philipp Zabel <p.zabel@pengutronix.de> - 2017-08-21 10:30 +0200

csiph-web