[PATCH v3 1/9] ASoC: rt5514: Switch to snd_soc_register_codec

Path	csiph.com!xmission!news.neodome.net!news.redatomik.org!aioe.org!bofh.it!news.nic.it!robomod
From	Jeffy Chen <jeffy.chen@rock-chips.com>
Newsgroups	linux.kernel
Subject	[PATCH v3 1/9] ASoC: rt5514: Switch to snd_soc_register_codec
Date	Thu, 17 Aug 2017 06:50:02 +0200
Message-ID	<ufkUO-8bv-23@gated-at.bofh.it> (permalink)
References	<ufkUN-8bv-7@gated-at.bofh.it>
X-263anti-Spam	KSV:0;
X-Mail-Delivery	1
X-Abs-Checked	4
X-Rl-Sender	jeffy.chen@rock-chips.com
X-Fst-To	linux-kernel@vger.kernel.org
X-Sender-IP	103.29.142.67
X-Login-Name	jeffy.chen@rock-chips.com
X-Unique-Tag	<069636ca5a40584fa63dc23e6c82f5dc>
X-Sender	cjf@rock-chips.com
X-Mailer	git-send-email 2.11.0
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	67
Organization	linux.* mail to news gateway
X-Original-Cc	briannorris@chromium.org, mka@chromium.org, dianders@chromium.org, Jeffy Chen <jeffy.chen@rock-chips.com>, Jaroslav Kysela <perex@perex.cz>, alsa-devel@alsa-project.org, Mark Brown <broonie@kernel.org>, Oder Chiou <oder_chiou@realtek.com>, Takashi Iwai <tiwai@suse.com>, Liam Girdwood <lgirdwood@gmail.com>, Bard Liao <bardliao@realtek.com>
X-Original-Date	Thu, 17 Aug 2017 12:44:09 +0800
X-Original-Message-ID	<20170817044417.22069-2-jeffy.chen@rock-chips.com>
X-Original-References	<20170817044417.22069-1-jeffy.chen@rock-chips.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1713536

Show key headers only | View raw

Currently we are using devm_snd_soc_register_component, which would
use legacy dai name.

Switch to snd_soc_register_codec to use dai driver name.

Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
---

Changes in v3: None
Changes in v2: None

 sound/soc/codecs/rt5514-spi.c | 19 ++++++++++++++-----
 1 file changed, 14 insertions(+), 5 deletions(-)

diff --git a/sound/soc/codecs/rt5514-spi.c b/sound/soc/codecs/rt5514-spi.c
index 640193d845be..ad6bc51dd82a 100644
--- a/sound/soc/codecs/rt5514-spi.c
+++ b/sound/soc/codecs/rt5514-spi.c
@@ -277,8 +277,10 @@ static struct snd_soc_platform_driver rt5514_spi_platform = {
 	.ops = &rt5514_spi_pcm_ops,
 };
 
-static const struct snd_soc_component_driver rt5514_spi_dai_component = {
-	.name		= "rt5514-spi-dai",
+static const struct snd_soc_codec_driver rt5514_spi_dai_codec = {
+	.component_driver = {
+		.name = "rt5514-spi-dai",
+	},
 };
 
 /**
@@ -426,9 +428,8 @@ static int rt5514_spi_probe(struct spi_device *spi)
 		return ret;
 	}
 
-	ret = devm_snd_soc_register_component(&spi->dev,
-					      &rt5514_spi_dai_component,
-					      &rt5514_spi_dai, 1);
+	ret = snd_soc_register_codec(&spi->dev, &rt5514_spi_dai_codec,
+				     &rt5514_spi_dai, 1);
 	if (ret < 0) {
 		dev_err(&spi->dev, "Failed to register component.\n");
 		return ret;
@@ -437,6 +438,13 @@ static int rt5514_spi_probe(struct spi_device *spi)
 	return 0;
 }
 
+static int rt5514_spi_remove(struct spi_device *spi)
+{
+	snd_soc_unregister_codec(&spi->dev);
+
+	return 0;
+}
+
 static const struct of_device_id rt5514_of_match[] = {
 	{ .compatible = "realtek,rt5514", },
 	{},
@@ -449,6 +457,7 @@ static struct spi_driver rt5514_spi_driver = {
 		.of_match_table = of_match_ptr(rt5514_of_match),
 	},
 	.probe = rt5514_spi_probe,
+	.remove = rt5514_spi_remove,
 };
 module_spi_driver(rt5514_spi_driver);
 
-- 
2.11.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 1/9] ASoC: rt5514: Switch to snd_soc_register_codec Jeffy Chen <jeffy.chen@rock-chips.com> - 2017-08-17 06:50 +0200
  Re: [PATCH v3 1/9] ASoC: rt5514: Switch to snd_soc_register_codec Mark Brown <broonie@kernel.org> - 2017-08-17 19:20 +0200
    Re: [PATCH v3 1/9] ASoC: rt5514: Switch to snd_soc_register_codec jeffy <jeffy.chen@rock-chips.com> - 2017-08-18 04:50 +0200

csiph-web