Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1713409

[PATCHv3 1/2] init: Move stack canary initialization after setup_arch

Show all headers | View raw

From: Laura Abbott <lauraa@codeaurora.org>


Stack canary intialization involves getting a random number.
Getting this random number may involve accessing caches or other
architectural specific features which are not available until
after the architecture is setup. Move the stack canary initialization
later to accomodate this.

Acked-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Laura Abbott <lauraa@codeaurora.org>
Signed-off-by: Laura Abbott <labbott@redhat.com>
---
v3: Ack from Kees
---
 init/main.c | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/init/main.c b/init/main.c
index 052481fbe363..21d599eaad06 100644
--- a/init/main.c
+++ b/init/main.c
@@ -515,12 +515,6 @@ asmlinkage __visible void __init start_kernel(void)
 	smp_setup_processor_id();
 	debug_objects_early_init();
 
-	/*
-	 * Set up the initial canary ASAP:
-	 */
-	add_latent_entropy();
-	boot_init_stack_canary();
-
 	cgroup_init_early();
 
 	local_irq_disable();
@@ -534,6 +528,11 @@ asmlinkage __visible void __init start_kernel(void)
 	page_address_init();
 	pr_notice("%s", linux_banner);
 	setup_arch(&command_line);
+	/*
+	 * Set up the the initial canary and entropy after arch
+	 */
+	add_latent_entropy();
+	boot_init_stack_canary();
 	mm_init_cpumask(&init_mm);
 	setup_command_line(command_line);
 	setup_nr_cpu_ids();
-- 
2.13.0

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCHv3 0/2] Command line randomness Laura Abbott <labbott@redhat.com> - 2017-08-17 01:20 +0200
  [PATCHv3 2/2] extract early boot entropy from the passed cmdline Laura Abbott <labbott@redhat.com> - 2017-08-17 01:20 +0200
    Re: [PATCHv3 2/2] extract early boot entropy from the passed cmdline Kees Cook <keescook@chromium.org> - 2017-08-17 01:30 +0200
    Re: [PATCHv3 2/2] extract early boot entropy from the passed cmdline Theodore Ts'o <tytso@mit.edu> - 2017-08-17 05:40 +0200
      Re: [PATCHv3 2/2] extract early boot entropy from the passed cmdline Daniel Micay <danielmicay@gmail.com> - 2017-08-17 06:30 +0200
        Re: [PATCHv3 2/2] extract early boot entropy from the passed cmdline Daniel Micay <danielmicay@gmail.com> - 2017-08-17 23:00 +0200
          Re: [PATCHv3 2/2] extract early boot entropy from the passed cmdline Theodore Ts'o <tytso@mit.edu> - 2017-08-17 23:50 +0200
  [PATCHv3 1/2] init: Move stack canary initialization after setup_arch Laura Abbott <labbott@redhat.com> - 2017-08-17 01:20 +0200

csiph-web