Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1713330

Re: [tpmdd-devel] [PATCH v2] tpm_tis: fix stall after iowrite*()s

Show all headers | View raw

On 8/15/2017 4:13 PM, Haris Okanovic wrote:
> ioread8() operations to TPM MMIO addresses can stall the cpu when
> immediately following a sequence of iowrite*()'s to the same region.
> 
> For example, cyclitest measures ~400us latency spikes when a non-RT
> usermode application communicates with an SPI-based TPM chip (Intel Atom
> E3940 system, PREEMPT_RT_FULL kernel). The spikes are caused by a
> stalling ioread8() operation following a sequence of 30+ iowrite8()s to
> the same address. I believe this happens because the write sequence is
> buffered (in cpu or somewhere along the bus), and gets flushed on the
> first LOAD instruction (ioread*()) that follows.
> 
> The enclosed change appears to fix this issue: read the TPM chip's
> access register (status code) after every iowrite*() operation to
> amortize the cost of flushing data to chip across multiple instructions.

I worry a bit about "appears to fix".  It seems odd that the TPM device 
driver would be the first code to uncover this.  Can anyone confirm that 
the chipset does indeed have this bug?

I'd also like an indication of the performance penalty.  We're doing a 
lot of work to improve the performance and I worry that "do a read after 
every write" will have a performance impact.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2] tpm_tis: fix stall after iowrite*()s Haris Okanovic <haris.okanovic@ni.com> - 2017-08-15 22:20 +0200
  Re: [tpmdd-devel] [PATCH v2] tpm_tis: fix stall after iowrite*()s Ken Goldman <kgold@linux.vnet.ibm.com> - 2017-08-16 23:20 +0200
    Re: [tpmdd-devel] [PATCH v2] tpm_tis: fix stall after iowrite*()s Alexander Stein <alexander.stein@systec-electronic.com> - 2017-08-17 08:00 +0200
    Re: [tpmdd-devel] [PATCH v2] tpm_tis: fix stall after iowrite*()s Sebastian Andrzej Siewior <sebastian.siewior@linutronix.de> - 2017-08-17 12:40 +0200
      Re: [tpmdd-devel] [PATCH v2] tpm_tis: fix stall after iowrite*()s Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2017-08-17 19:20 +0200
        Re: [tpmdd-devel] [PATCH v2] tpm_tis: fix stall after iowrite*()s Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-08-19 19:10 +0200

csiph-web