Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1713302

[PATCH 05/10] perf scripts python: Fix query in call-graph-from-postgresql.py

Show all headers | View raw

From: Adrian Hunter <adrian.hunter@intel.com>

Add a missing space which seemed not to affect PostgreSQL but upsets
SQLite.

Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Link: http://lkml.kernel.org/r/1501749090-20357-3-git-send-email-adrian.hunter@intel.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/scripts/python/call-graph-from-postgresql.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/scripts/python/call-graph-from-postgresql.py b/tools/perf/scripts/python/call-graph-from-postgresql.py
index e78fdc2a5a9d..ed9f7f3ccf22 100644
--- a/tools/perf/scripts/python/call-graph-from-postgresql.py
+++ b/tools/perf/scripts/python/call-graph-from-postgresql.py
@@ -160,7 +160,7 @@ class TreeItem():
 				  '( SELECT short_name FROM dsos WHERE id = ( SELECT dso_id FROM symbols WHERE id = ( SELECT symbol_id FROM call_paths WHERE id = call_path_id ) ) ), '
 				  '( SELECT ip FROM call_paths where id = call_path_id ) '
 				  'FROM calls WHERE parent_call_path_id = ' + str(self.call_path_id) + ' AND comm_id = ' + str(self.comm_id) + ' AND thread_id = ' + str(self.thread_id) +
-				  'ORDER BY call_path_id')
+				  ' ORDER BY call_path_id')
 		if not ret:
 			raise Exception("Query failed: " + query.lastError().text())
 		last_call_path_id = 0
-- 
2.13.5

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[GIT PULL 00/10] perf/core improvements and fixes Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-08-16 22:30 +0200
  [PATCH 07/10] perf script python: Rename call-graph-from-postgresql.py to call-graph-from-sql.py Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-08-16 22:30 +0200
  [PATCH 02/10] perf test shell: Check if 'perf probe' is available, skip tests if not Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-08-16 22:30 +0200
  [PATCH 04/10] perf scripts python: Fix missing call_path_id in export-to-postgresql script Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-08-16 22:30 +0200
  [PATCH 06/10] perf script python: Add support for exporting to sqlite3 Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-08-16 22:30 +0200
  [PATCH 08/10] perf script python: Add support for sqlite3 to call-graph-from-sql.py Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-08-16 22:30 +0200
  [PATCH 05/10] perf scripts python: Fix query in call-graph-from-postgresql.py Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-08-16 22:30 +0200
  [PATCH 10/10] perf test shell: Replace '|&' with '2>&1 |' to work with more shells Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-08-16 22:30 +0200
  [PATCH 09/10] perf bpf: Fix endianness problem when loading parameters in prologue Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-08-16 22:30 +0200
  [PATCH 01/10] perf tests shell: Remove duplicate skip_if_no_debuginfo() function Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-08-16 22:30 +0200
  Re: [GIT PULL 00/10] perf/core improvements and fixes Ingo Molnar <mingo@kernel.org> - 2017-08-17 09:50 +0200

csiph-web