Re: [PATCH] xen/pvcalls: use WARN_ON(1) instead of __WARN()

From	Boris Ostrovsky <boris.ostrovsky@oracle.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] xen/pvcalls: use WARN_ON(1) instead of __WARN()
Date	2017-08-16 20:40 +0200
Message-ID	<ufbot-28f-5@gated-at.bofh.it> (permalink)
References	<u5IOK-73n-23@gated-at.bofh.it> <u5LMB-ou-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 07/21/2017 03:26 PM, Stefano Stabellini wrote:
> On Fri, 21 Jul 2017, Arnd Bergmann wrote:
>> __WARN() is an internal helper that is only available on
>> some architectures, but causes a build error e.g. on ARM64
>> in some configurations:
>>
>> drivers/xen/pvcalls-back.c: In function 'set_backend_state':
>> drivers/xen/pvcalls-back.c:1097:5: error: implicit declaration of function '__WARN' [-Werror=implicit-function-declaration]
>>
>> Unfortunately, there is no equivalent of BUG() that takes no
>> arguments, but WARN_ON(1) is commonly used in other drivers
>> and works on all configurations.
>>
>> Fixes: 7160378206b2 ("xen/pvcalls: xenbus state handling")
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
>

Applied to for-linus-4.14

-boris

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] xen/pvcalls: use WARN_ON(1) instead of __WARN() Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2017-08-16 20:40 +0200

csiph-web