Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1713151

Re: [PATCH v2] completion: Document that reinit_completion() must be called after complete_all()

From Linus Torvalds <torvalds@linux-foundation.org>
Newsgroups linux.kernel
Subject Re: [PATCH v2] completion: Document that reinit_completion() must be called after complete_all()
Date 2017-08-16 19:20 +0200
Message-ID <ufa95-1so-43@gated-at.bofh.it> (permalink)
References <ufa94-1so-25@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Wed, Aug 16, 2017 at 10:12 AM, Steven Rostedt <rostedt@goodmis.org> wrote:
> The function complete_all() modifies the completion "done" variable to
> UINT_MAX, and no other caller (wait_for_completion(), etc) will modify
> it back to zero. That means that any call to complete_all() must have a
> reinit_completion() before that completion can be used again.
>
> Document this fact by the complete_all() function.
>
> Also document that completion_done() will always return true if
> complete_all() is called.

Ack. Do I take it directly or is it indended for some other tree?

               Linus

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v2] completion: Document that reinit_completion() must be   called after complete_all() Steven Rostedt <rostedt@goodmis.org> - 2017-08-16 19:20 +0200
  Re: [PATCH v2] completion: Document that reinit_completion() must be  called after complete_all() Linus Torvalds <torvalds@linux-foundation.org> - 2017-08-16 19:20 +0200
    Re: [PATCH v2] completion: Document that reinit_completion() must  be called after complete_all() Steven Rostedt <rostedt@goodmis.org> - 2017-08-16 19:30 +0200
    Re: [PATCH v2] completion: Document that reinit_completion() must be  called after complete_all() Ingo Molnar <mingo@kernel.org> - 2017-08-16 20:10 +0200
      Re: [PATCH v2] completion: Document that reinit_completion() must be  called after complete_all() Linus Torvalds <torvalds@linux-foundation.org> - 2017-08-16 21:00 +0200
  [tip:sched/core] sched/completion: Document that  reinit_completion() must be called after complete_all() tip-bot for Steven Rostedt <tipbot@zytor.com> - 2017-08-16 20:20 +0200

csiph-web