Re: [PATCH] Revert "staging: fsl-mc: be consistent when checking strcmp() return"

From	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] Revert "staging: fsl-mc: be consistent when checking strcmp() return"
Date	2017-08-16 19:20 +0200
Message-ID	<ufa95-1so-35@gated-at.bofh.it> (permalink)
References	<ufa94-1so-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Aug 16, 2017 at 06:12:00PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> The previous fix removed the equal to zero comparisons by the strcmps and
> now the function always returns true. Revert this change to restore the
> original correctly functioning code.
> 
> Detected by CoverityScan, CID#1452267 ("Constant expression result")
> 
> This reverts commit b93ad9a067e1515af42da7d56bc61f1a25075f94.

So this should say:
Fixes: XXXXXX

right?

And it should get into 4.13-final, right?  Or if not, at least
backported to 4.13-stable?

Can you please resend it with the fixes tag?

thanks,

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] Revert "staging: fsl-mc: be consistent when checking strcmp() return" Colin King <colin.king@canonical.com> - 2017-08-16 19:20 +0200
  Re: [PATCH] Revert "staging: fsl-mc: be consistent when checking  strcmp() return" Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-08-16 19:20 +0200

csiph-web