Re: [PATCH v3] blktrace: Fix potentail deadlock between delete & sysfs ops

From	Waiman Long <longman@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3] blktrace: Fix potentail deadlock between delete & sysfs ops
Date	2017-08-18 22:00 +0200
Message-ID	<ufVB1-89n-31@gated-at.bofh.it> (permalink)
References	<ufTIS-6Yr-23@gated-at.bofh.it> <ufTSy-7gI-9@gated-at.bofh.it>
Organization	Red Hat

Show all headers | View raw

On 08/18/2017 02:07 PM, Bart Van Assche wrote:
> On Fri, 2017-08-18 at 13:54 -0400, Waiman Long wrote:
>> Instead, a global blktrace
>> mutex will be used to serialize the read/write of the blktrace sysfs
>> attributes.
> Hello Waiman,
>
> Using a mutex to serialize code is wrong. What is needed is exact
> documentation of what data structures and/or member variables are
> protected by bdev->bd_mutex and by blktrace_mutex.

Yes, I missed the blk_trace_ioctl(). I should have modified it to use
blktrace_mutex as well.

> Also, please spell "potential" correctly in the subject of this patch.

Will do.

Thanks,
Longman

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v3] blktrace: Fix potentail deadlock between delete & sysfs ops Waiman Long <longman@redhat.com> - 2017-08-18 20:00 +0200
  Re: [PATCH v3] blktrace: Fix potentail deadlock between delete &  sysfs ops Bart Van Assche <Bart.VanAssche@wdc.com> - 2017-08-18 20:10 +0200
    Re: [PATCH v3] blktrace: Fix potentail deadlock between delete &  sysfs ops Waiman Long <longman@redhat.com> - 2017-08-18 22:00 +0200

csiph-web