RE: [PATCH net-next] net: hns3: Add support to change MTU in hardware & netdev

From	Salil Mehta <salil.mehta@huawei.com>
Newsgroups	linux.kernel
Subject	RE: [PATCH net-next] net: hns3: Add support to change MTU in hardware & netdev
Date	2017-08-18 19:10 +0200
Message-ID	<ufSWu-6HW-15@gated-at.bofh.it> (permalink)
References	(1 earlier) <ufPFj-4ln-89@gated-at.bofh.it> <ufQUG-58U-17@gated-at.bofh.it> <ufR4n-5rS-51@gated-at.bofh.it> <ufRxp-5DE-49@gated-at.bofh.it> <ufS0r-63B-29@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Andrew,

> > -----Original Message-----
> > From: Andrew Lunn [mailto:andrew@lunn.ch]
> > Sent: Friday, August 18, 2017 5:02 PM
> > To: Salil Mehta
> > Cc: davem@davemloft.net; Zhuangyuzeng (Yisen); lipeng (Y);
> > mehta.salil.lnk@gmail.com; netdev@vger.kernel.org; linux-
> > kernel@vger.kernel.org; linux-rdma@vger.kernel.org; Linuxarm
> > Subject: Re: [PATCH net-next] net: hns3: Add support to change MTU in
> > hardware & netdev
> >
> > > for example,
> > > file: drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c
> > > static int init_one(struct pci_dev *pdev, const struct
> pci_device_id
> > *ent)
> > >
> > >  		netdev->priv_flags |= IFF_UNICAST_FLT;
> > >
> > > +		/* MTU range: 81 - 9600 */
> > > +		netdev->min_mtu = 81;
> > > +		netdev->max_mtu = MAX_MTU;
> >
> > In this cause, the driver is not using the default values. So it sets
> > them.
> >
> > Anyway, try it. After your alloc_etherdev_mqs(), print the value of
> > min_mtu. It should already be set to MIN_ETH_MTU.
> I understand your point. In this case, I would like to keep the
> range being set by the driver just to be more explicit.
> So for now keep this initialization in the driver?
Removed the min_mtu initialization from the driver code and added a
comment over it to be explicit. Please have a look at the V2 patch.

Thanks
Salil

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH net-next] net: hns3: Add support to change MTU in hardware & netdev Salil Mehta <salil.mehta@huawei.com> - 2017-08-18 13:40 +0200
  Re: [PATCH net-next] net: hns3: Add support to change MTU in  hardware & netdev Andrew Lunn <andrew@lunn.ch> - 2017-08-18 15:40 +0200
    RE: [PATCH net-next] net: hns3: Add support to change MTU in  hardware & netdev Salil Mehta <salil.mehta@huawei.com> - 2017-08-18 17:00 +0200
      Re: [PATCH net-next] net: hns3: Add support to change MTU in  hardware & netdev Andrew Lunn <andrew@lunn.ch> - 2017-08-18 17:10 +0200
        RE: [PATCH net-next] net: hns3: Add support to change MTU in  hardware & netdev Salil Mehta <salil.mehta@huawei.com> - 2017-08-18 17:40 +0200
          Re: [PATCH net-next] net: hns3: Add support to change MTU in  hardware & netdev Andrew Lunn <andrew@lunn.ch> - 2017-08-18 18:10 +0200
            RE: [PATCH net-next] net: hns3: Add support to change MTU in  hardware & netdev Salil Mehta <salil.mehta@huawei.com> - 2017-08-18 18:20 +0200
            RE: [PATCH net-next] net: hns3: Add support to change MTU in  hardware & netdev Salil Mehta <salil.mehta@huawei.com> - 2017-08-18 19:10 +0200

csiph-web