Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1715128

Re: [PATCH] MIPS: dts: ralink: Add Mediatek MT7628A SoC

Show all headers | View raw

On Fri, Aug 18, 2017 at 4:42 AM, Harvey Hunt <Harvey.Hunt@imgtec.com> wrote:
> Hi Rob,
>
> Thanks for the review.
>
>
> On 17/08/17 22:34, Rob Herring wrote:
>>
>> On Tue, Aug 15, 2017 at 05:28:50PM +0100, Harvey Hunt wrote:
>>>
>>> The MT7628A is the successor to the MT7620 and pin compatible with the
>>> MT7688A, although the latter supports only a 1T1R antenna rather than
>>> a 2T2R antenna.

[...]

>>> +               uartlite@c00 {
>>
>>
>> serial@c00
>>
>> And so on. IOW, use standard, generic node names as defined in the DT
>> spec.
>
>
>
> The clocks for the UARTs are using the device names "uartlite", "uart1" and
> "uart2" (as defined in arch/mips/ralink/mt7620.c).

You can't add clocks to the DT? Looks like mt76x8 at least should be
pretty easy with some fixed clocks.

Depending if backwards compatibility (old dtb working on new kernel)
is a concern on these platforms, you could just change all the names
both in the kernel and dts.

> Changing the name of the DT nodes causes the serial driver to bail as it
> can't find the clock for the device.
>
> arch/mips/boot/dts/ralink/mt7620a.dtsi is already using the uartlite name,
> although it hasn't been documented...

Generally the kernel shouldn't care what the names are (though you can
match by name, it's not widely used).

In any case, I guess fixing this can be done later.

Rob

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] MIPS: dts: ralink: Add Mediatek MT7628A SoC Harvey Hunt <harvey.hunt@imgtec.com> - 2017-08-15 18:30 +0200
  Re: [PATCH] MIPS: dts: ralink: Add Mediatek MT7628A SoC Rob Herring <robh@kernel.org> - 2017-08-17 23:40 +0200
    Re: [PATCH] MIPS: dts: ralink: Add Mediatek MT7628A SoC Harvey Hunt <Harvey.Hunt@imgtec.com> - 2017-08-18 11:50 +0200
      Re: [PATCH] MIPS: dts: ralink: Add Mediatek MT7628A SoC Rob Herring <robh@kernel.org> - 2017-08-18 16:10 +0200
        Re: [PATCH] MIPS: dts: ralink: Add Mediatek MT7628A SoC Harvey Hunt <Harvey.Hunt@imgtec.com> - 2017-08-18 16:20 +0200
          Re: [PATCH] MIPS: dts: ralink: Add Mediatek MT7628A SoC Rob Herring <robh@kernel.org> - 2017-08-18 17:40 +0200

csiph-web