Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1715114

[PATCH 3.16 005/134] ima: accept previously set IMA_NEW_FILE

Show all headers | View raw

3.16.47-rc1 review patch.  If anyone has any objections, please let me know.

------------------

From: Daniel Glöckner <dg@emlix.com>

commit 1ac202e978e18f045006d75bd549612620c6ec3a upstream.

Modifying the attributes of a file makes ima_inode_post_setattr reset
the IMA cache flags. So if the file, which has just been created,
is opened a second time before the first file descriptor is closed,
verification fails since the security.ima xattr has not been written
yet. We therefore have to look at the IMA_NEW_FILE even if the file
already existed.

With this patch there should no longer be an error when cat tries to
open testfile:

$ rm -f testfile
$ ( echo test >&3 ; touch testfile ; cat testfile ) 3>testfile

A file being new is no reason to accept that it is missing a digital
signature demanded by the policy.

Signed-off-by: Daniel Glöckner <dg@emlix.com>
Signed-off-by: Mimi Zohar <zohar@linux.vnet.ibm.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
---
 security/integrity/ima/ima_appraise.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

--- a/security/integrity/ima/ima_appraise.c
+++ b/security/integrity/ima/ima_appraise.c
@@ -195,10 +195,11 @@ int ima_appraise_measurement(int func, s
 
 		cause = "missing-hash";
 		status = INTEGRITY_NOLABEL;
-		if (opened & FILE_CREATED) {
+		if (opened & FILE_CREATED)
 			iint->flags |= IMA_NEW_FILE;
+		if ((iint->flags & IMA_NEW_FILE) &&
+		    !(iint->flags & IMA_DIGSIG_REQUIRED))
 			status = INTEGRITY_PASS;
-		}
 		goto out;
 	}
 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 3.16 000/134] 3.16.47-rc1 review Ben Hutchings <ben@decadent.org.uk> - 2017-08-18 16:10 +0200
  [PATCH 3.16 005/134] ima: accept previously set IMA_NEW_FILE Ben Hutchings <ben@decadent.org.uk> - 2017-08-18 16:10 +0200
  [PATCH 3.16 010/134] pinctrl: sh-pfc: Update info pointer after  SoC-specific init Ben Hutchings <ben@decadent.org.uk> - 2017-08-18 16:10 +0200
  [PATCH 3.16 008/134] perf hists browser: Fix typo in function  switch_data_file Ben Hutchings <ben@decadent.org.uk> - 2017-08-18 16:10 +0200
  [PATCH 3.16 015/134] [media] serial_ir: iommap is a memory  address, not bool Ben Hutchings <ben@decadent.org.uk> - 2017-08-18 16:10 +0200
  [PATCH 3.16 016/134] [media] mceusb: fix NULL-deref at probe Ben Hutchings <ben@decadent.org.uk> - 2017-08-18 16:10 +0200
  [PATCH 3.16 013/134] usb: hub: Do not attempt to autosuspend  disconnected devices Ben Hutchings <ben@decadent.org.uk> - 2017-08-18 16:10 +0200
  [PATCH 3.16 018/134] USB: Proper handling of Race Condition when  two USB class drivers try to call init_usb_class simultaneously Ben Hutchings <ben@decadent.org.uk> - 2017-08-18 16:10 +0200
  [PATCH 3.16 012/134] usb: hub: Fix error loop seen after hub  communication errors Ben Hutchings <ben@decadent.org.uk> - 2017-08-18 16:10 +0200
  [PATCH 3.16 006/134] ath9k_htc: Add new USB ID Ben Hutchings <ben@decadent.org.uk> - 2017-08-18 16:10 +0200
  [PATCH 3.16 019/134] cdc-acm: fix possible invalid access when  processing notification Ben Hutchings <ben@decadent.org.uk> - 2017-08-18 16:10 +0200
  [PATCH 3.16 014/134] mtd: nand: fsmc: fix NAND width handling Ben Hutchings <ben@decadent.org.uk> - 2017-08-18 16:10 +0200
  [PATCH 3.16 007/134] ath9k_htc: Add support of AirTies 1eda:2315  AR9271 device Ben Hutchings <ben@decadent.org.uk> - 2017-08-18 16:10 +0200
  [PATCH 3.16 002/134] staging: comedi: jr3_pci: fix possible null  pointer dereference Ben Hutchings <ben@decadent.org.uk> - 2017-08-18 16:20 +0200
  Re: [PATCH 3.16 000/134] 3.16.47-rc1 review Guenter Roeck <linux@roeck-us.net> - 2017-08-18 17:00 +0200
    Re: [PATCH 3.16 000/134] 3.16.47-rc1 review Ben Hutchings <ben@decadent.org.uk> - 2017-08-18 22:20 +0200

csiph-web