Re: [PATCH v2 6/6] kernel: tracepoints: add support for relative references

From	Steven Rostedt <rostedt@goodmis.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 6/6] kernel: tracepoints: add support for relative references
Date	2017-08-18 16:00 +0200
Message-ID	<ufPYD-4vA-61@gated-at.bofh.it> (permalink)
References	<ufNDr-30g-3@gated-at.bofh.it> <ufNDt-30g-23@gated-at.bofh.it> <ufNWO-37L-21@gated-at.bofh.it> <ufPOW-4q2-19@gated-at.bofh.it> <ufPOY-4q2-55@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, 18 Aug 2017 14:44:15 +0100
Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:

> >> It appears the stuff above needs to be move inside the double-include
> >> guard (which oddly enough does not cover the entire file)  
> >
> > Why was this moved to the header file? To fulfill some checkpatch
> > warning?
> >  
> 
> Yes.

My preference is to ignore that checkpatch warning. The section
variables are created by linker magic, and not normal "extern"
variables. They are only used in one location, and I like to keep them
where they are used, and not be something other places might think they
can be used. In other words, keep them by the C code, and out of
headers.

Tracepoints and linker/asm work always triggers a lot of bogus
checkpatch warnings. Which is unfortunate. :-/

Thanks!

-- Steve

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/6] add support for relative references in special sections Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2017-08-18 13:30 +0200
  [PATCH v2 6/6] kernel: tracepoints: add support for relative references Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2017-08-18 13:30 +0200
    Re: [PATCH v2 6/6] kernel: tracepoints: add support for relative references Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2017-08-18 13:50 +0200
      Re: [PATCH v2 6/6] kernel: tracepoints: add support for relative  references Steven Rostedt <rostedt@goodmis.org> - 2017-08-18 15:50 +0200
        Re: [PATCH v2 6/6] kernel: tracepoints: add support for relative references Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2017-08-18 15:50 +0200
          Re: [PATCH v2 6/6] kernel: tracepoints: add support for relative references Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2017-08-18 16:00 +0200
          Re: [PATCH v2 6/6] kernel: tracepoints: add support for relative  references Steven Rostedt <rostedt@goodmis.org> - 2017-08-18 16:00 +0200

csiph-web