Re: [PATCH 3/3] KVM: x86: fix use of L1 MMIO areas in nested guests

From	Paolo Bonzini <pbonzini@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/3] KVM: x86: fix use of L1 MMIO areas in nested guests
Date	2017-08-18 14:40 +0200
Message-ID	<ufOJd-3Ie-25@gated-at.bofh.it> (permalink)
References	<ufvZU-7qv-15@gated-at.bofh.it> <ufvZU-7qv-31@gated-at.bofh.it> <ufKvT-Mj-5@gated-at.bofh.it> <ufOJc-3Ie-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 18/08/2017 14:35, Radim Krčmář wrote:
> 
>>> diff --git a/arch/x86/kvm/x86.h b/arch/x86/kvm/x86.h
>>> @@ -90,7 +90,11 @@ static inline u32 bit(int bitno)
>>>  static inline void vcpu_cache_mmio_info(struct kvm_vcpu *vcpu,
>>>  					gva_t gva, gfn_t gfn, unsigned access)
>>>  {
>>> -	vcpu->arch.mmio_gva = gva & PAGE_MASK;
>>> +	/*
>>> +	 * If this is a shadow nested page table, the "GVA" is
>> s/"GVA"/GVA/ ?
> I prefer the former, we're talking about "gva_t gva" that isn't GVA. :)

Exactly. :)

Paolo

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/3] KVM: MMU: pending MMU and nEPT patches Paolo Bonzini <pbonzini@redhat.com> - 2017-08-17 18:40 +0200
  [PATCH 3/3] KVM: x86: fix use of L1 MMIO areas in nested guests Paolo Bonzini <pbonzini@redhat.com> - 2017-08-17 18:40 +0200
    Re: [PATCH 3/3] KVM: x86: fix use of L1 MMIO areas in nested guests David Hildenbrand <david@redhat.com> - 2017-08-18 10:10 +0200
      Re: [PATCH 3/3] KVM: x86: fix use of L1 MMIO areas in nested guests Radim Krčmář <rkrcmar@redhat.com> - 2017-08-18 14:40 +0200
        Re: [PATCH 3/3] KVM: x86: fix use of L1 MMIO areas in nested guests Paolo Bonzini <pbonzini@redhat.com> - 2017-08-18 14:40 +0200

csiph-web