Re: [PATCH 5/5] Use func instead of function name

From	Michael Ellerman <mpe@ellerman.id.au>
Newsgroups	linux.kernel
Subject	Re: [PATCH 5/5] Use __func__ instead of function name
Date	2017-08-18 13:30 +0200
Message-ID	<ufNDs-30g-15@gated-at.bofh.it> (permalink)
References	<u8ume-7n2-5@gated-at.bofh.it> <u8ume-7n2-7@gated-at.bofh.it> <ufKvT-Mj-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Michal Suchánek <msuchanek@suse.de> writes:

> On 2017-07-29 09:24, SZ Lin wrote:
>> Fix following checkpatch.pl warning:
>> WARNING: Prefer using '"%s...", __func__' to using
>> the function's name, in a string
>> 
>> Signed-off-by: SZ Lin <sz.lin@moxa.com>
>> ---
>>  drivers/char/tpm/tpm_ibmvtpm.c | 12 ++++++------
>>  1 file changed, 6 insertions(+), 6 deletions(-)
>> 
>> diff --git a/drivers/char/tpm/tpm_ibmvtpm.c 
>> b/drivers/char/tpm/tpm_ibmvtpm.c
>> index e75a674b44ac..2d33acc43e25 100644
>> --- a/drivers/char/tpm/tpm_ibmvtpm.c
>> +++ b/drivers/char/tpm/tpm_ibmvtpm.c
>> @@ -151,7 +151,7 @@ static int tpm_ibmvtpm_send(struct tpm_chip *chip,
>> u8 *buf, size_t count)
>>  	rc = ibmvtpm_send_crq(ibmvtpm->vdev, be64_to_cpu(word[0]),
>>  			      be64_to_cpu(word[1]));
>>  	if (rc != H_SUCCESS) {
>> -		dev_err(ibmvtpm->dev, "tpm_ibmvtpm_send failed rc=%d\n", rc);
>> +		dev_err(ibmvtpm->dev, "%s failed rc=%d\n", __func__, rc);
>
> Can function name contain a %?

Let's hope not.

$ git grep "%s.*__func__" | wc -l
16937

cheers

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 5/5] Use __func__ instead of function name Michal Suchánek <msuchanek@suse.de> - 2017-08-18 10:10 +0200
  Re: [PATCH 5/5] Use __func__ instead of function name Michael Ellerman <mpe@ellerman.id.au> - 2017-08-18 13:30 +0200

csiph-web