Re: [PATCH v2 15/16] dmaengine: bcm-sba-raid: Add debugfs support

From	Anup Patel <anup.patel@broadcom.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 15/16] dmaengine: bcm-sba-raid: Add debugfs support
Date	2017-08-18 07:30 +0200
Message-ID	<ufI14-7kE-13@gated-at.bofh.it> (permalink)
References	<u9CKK-2Ig-15@gated-at.bofh.it> <u9CUr-2Qq-35@gated-at.bofh.it> <ufnSG-1MZ-21@gated-at.bofh.it> <ufHHH-7cn-3@gated-at.bofh.it> <ufI13-7kE-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Aug 18, 2017 at 10:56 AM, Vinod Koul <vinod.koul@intel.com> wrote:
> On Fri, Aug 18, 2017 at 10:33:54AM +0530, Anup Patel wrote:
>> On Thu, Aug 17, 2017 at 1:31 PM, Vinod Koul <vinod.koul@intel.com> wrote:
>> > On Tue, Aug 01, 2017 at 04:07:59PM +0530, Anup Patel wrote:
>> > why fail, debugfs should be an optional thingy, why would you want to fail here?
>>
>> Yes, we are handling the case when debugfs is not available
>> and skipping debugfs gracefully.
>>
>> If debugfs is available then failure of debugfs_create_dir()
>> should be reported.
>
> reported yes, bailing out on that err no..

OK, I will put dev_err() instead of bailing out.

Regards,
Anup

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2 15/16] dmaengine: bcm-sba-raid: Add debugfs support Vinod Koul <vinod.koul@intel.com> - 2017-08-17 10:00 +0200
  Re: [PATCH v2 15/16] dmaengine: bcm-sba-raid: Add debugfs support Anup Patel <anup.patel@broadcom.com> - 2017-08-18 07:10 +0200
    Re: [PATCH v2 15/16] dmaengine: bcm-sba-raid: Add debugfs support Vinod Koul <vinod.koul@intel.com> - 2017-08-18 07:30 +0200
      Re: [PATCH v2 15/16] dmaengine: bcm-sba-raid: Add debugfs support Anup Patel <anup.patel@broadcom.com> - 2017-08-18 07:30 +0200

csiph-web