Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1714569
| From | Vinod Koul <vinod.koul@intel.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2 03/16] dmaengine: bcm-sba-raid: Common flags for sba_request state and fence |
| Date | 2017-08-18 07:30 +0200 |
| Message-ID | <ufI13-7kE-1@gated-at.bofh.it> (permalink) |
| References | <u9CKK-2Ig-15@gated-at.bofh.it> <u9CKL-2Ig-39@gated-at.bofh.it> <ufjYK-7yX-11@gated-at.bofh.it> <ufHy2-6Rd-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Fri, Aug 18, 2017 at 10:26:54AM +0530, Anup Patel wrote: > On Thu, Aug 17, 2017 at 9:15 AM, Vinod Koul <vinod.koul@intel.com> wrote: > > On Tue, Aug 01, 2017 at 04:07:47PM +0530, Anup Patel wrote: > >> This patch merges sba_request state and fence into common > >> sba_request flags. Also, in-future we can extend sba_request > >> flags as required. > > > > and it also changes the flag values to bits, which I have no idea why that > > was done, care to explain that please... > > I thought its better to have separate bit each sba_request state so > that when a sba_request is accidentally in two states then we can > debug better. that is fine, but you need to comminucate the motivation behind such a change!! > > I will restore state values. either ways am okay, but if we are not using bits smartly then why to change -- ~Vinod
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH v2 03/16] dmaengine: bcm-sba-raid: Common flags for sba_request state and fence Vinod Koul <vinod.koul@intel.com> - 2017-08-17 05:50 +0200
Re: [PATCH v2 03/16] dmaengine: bcm-sba-raid: Common flags for sba_request state and fence Anup Patel <anup.patel@broadcom.com> - 2017-08-18 07:00 +0200
Re: [PATCH v2 03/16] dmaengine: bcm-sba-raid: Common flags for sba_request state and fence Vinod Koul <vinod.koul@intel.com> - 2017-08-18 07:30 +0200
Re: [PATCH v2 03/16] dmaengine: bcm-sba-raid: Common flags for sba_request state and fence Anup Patel <anup.patel@broadcom.com> - 2017-08-18 08:10 +0200
csiph-web