Re: [PATCH v2 01/16] dmaengine: bcm-sba-raid: Minor improvments in comments

Path	csiph.com!news.mixmin.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod
From	Anup Patel <anup.patel@broadcom.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 01/16] dmaengine: bcm-sba-raid: Minor improvments in comments
Date	Fri, 18 Aug 2017 07:00:02 +0200
Message-ID	<ufHy2-6Rd-1@gated-at.bofh.it> (permalink)
References	<u9CKK-2Ig-15@gated-at.bofh.it> <u9CKK-2Ig-25@gated-at.bofh.it> <ufjYK-7yX-15@gated-at.bofh.it>
X-Original-To	Vinod Koul <vinod.koul@intel.com>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=UtMo4W0zlc7oXNM1HkfFPbX9GS0ZwoPjWGBNDM1I584=; b=LIPy3nw7uOQY0AbYUQzvxZDDoAHvhEZppbEOElkeIuBNT2sY0AX3lrvGKnejaRpCeP upka7R8C7EbaZMoHNlV9Hv0tAOj3cXrxmUIcnrZLwgR9vPbgRJHeb94S2vlKR2i35Bkq aDPQ9ATaztSW5FilumxBAmPrPoSkoCDguiBdQ=
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=UtMo4W0zlc7oXNM1HkfFPbX9GS0ZwoPjWGBNDM1I584=; b=gUbvAItjSkDhuow089KvwOoxAmHIfN8s7UkYkuOYIiNs7JhRQ82rbJWk3yD5vgktXe NTc8pjPkVoKJH03xdF7EIbBeQ7uehbS8LojDXoaRa2G04izpHaVfNIMz73BhBLk1Q3Tw 32lHBltN7iMhl2RoR/5suXrC7ob5yu2UUjJDsjJw6OL8AsAoWX4Itrn1MNgOWMWuc+IM NtWoPKsKBD3gvsJ40CFzit26J1VB3kcpCWCByeYRyxIsZjkZA34beuO/aOFpbDh8aZLU hVMkRLCdGHkwRwhPIe2BpTUWp5J8K2yzNKISxd0e683mLLplFlRU3paTkDY5elvHl01u uLvA==
X-Gm-Message-State	AHYfb5iPKiVc35przw+Xz3l/t1dY0Nr8zajYePrwlu9eFrs8EpV6dNCc 5bueFatQ/F1S/6KQjU1lIl/Z6Ba0UpeM
X-Received	by 10.31.202.69 with SMTP id a66mr4566598vkg.66.1503032064085; Thu, 17 Aug 2017 21:54:24 -0700 (PDT)
MIME-Version	1.0
Content-Type	text/plain; charset="UTF-8"
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	61
Organization	linux.* mail to news gateway
X-Original-Cc	Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Dan Williams <dan.j.williams@intel.com>, Florian Fainelli <f.fainelli@gmail.com>, Scott Branden <sbranden@broadcom.com>, Ray Jui <rjui@broadcom.com>, Linux Kernel <linux-kernel@vger.kernel.org>, Linux ARM Kernel <linux-arm-kernel@lists.infradead.org>, Device Tree <devicetree@vger.kernel.org>, dmaengine@vger.kernel.org, BCM Kernel Feedback <bcm-kernel-feedback-list@broadcom.com>
X-Original-Date	Fri, 18 Aug 2017 10:24:23 +0530
X-Original-Message-ID	<CAALAos8D1K0omRQbpAYA4paA3-wds-g-+TARhwi7VEc-ajWo_g@mail.gmail.com>
X-Original-References	<1501583880-32072-1-git-send-email-anup.patel@broadcom.com> <1501583880-32072-2-git-send-email-anup.patel@broadcom.com> <20170817034441.GX3053@localhost>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1714560

Show key headers only | View raw

On Thu, Aug 17, 2017 at 9:14 AM, Vinod Koul <vinod.koul@intel.com> wrote:
> On Tue, Aug 01, 2017 at 04:07:45PM +0530, Anup Patel wrote:
>> Make section comments consistent across the Broadcom SBA RAID driver
>> by avoiding " SBA " in some of the comments.
>
> and you add more comments..

OK, I will add this to commit description.

>
>>
>> Signed-off-by: Anup Patel <anup.patel@broadcom.com>
>> ---
>>  drivers/dma/bcm-sba-raid.c | 9 ++++++---
>>  1 file changed, 6 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/dma/bcm-sba-raid.c b/drivers/dma/bcm-sba-raid.c
>> index e41bbc7..76999b7 100644
>> --- a/drivers/dma/bcm-sba-raid.c
>> +++ b/drivers/dma/bcm-sba-raid.c
>> @@ -48,7 +48,8 @@
>>
>>  #include "dmaengine.h"
>>
>> -/* SBA command related defines */
>> +/* ====== Driver macros and defines ===== */
>> +
>>  #define SBA_TYPE_SHIFT                                       48
>>  #define SBA_TYPE_MASK                                        GENMASK(1, 0)
>>  #define SBA_TYPE_A                                   0x0
>> @@ -88,6 +89,8 @@
>>  #define to_sba_device(dchan)         \
>>       container_of(dchan, struct sba_device, dma_chan)
>>
>> +/* ===== Driver data structures ===== */
>
> like this!!
>
>> +
>>  enum sba_request_state {
>>       SBA_REQUEST_STATE_FREE = 1,
>>       SBA_REQUEST_STATE_ALLOCED = 2,
>> @@ -164,7 +167,7 @@ struct sba_device {
>>       int reqs_free_count;
>>  };
>>
>> -/* ====== SBA command helper routines ===== */
>> +/* ====== Command helper routines ===== */
>>
>>  static inline u64 __pure sba_cmd_enc(u64 cmd, u32 val, u32 shift, u32 mask)
>>  {
>> @@ -196,7 +199,7 @@ static inline u32 __pure sba_cmd_pq_c_mdata(u32 d, u32 b1, u32 b0)
>>              ((d & SBA_C_MDATA_DNUM_MASK) << SBA_C_MDATA_DNUM_SHIFT);
>>  }
>>
>> -/* ====== Channel resource management routines ===== */
>> +/* ====== General helper routines ===== */
>>

Regards,
Anup

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2 01/16] dmaengine: bcm-sba-raid: Minor improvments in  comments Vinod Koul <vinod.koul@intel.com> - 2017-08-17 05:50 +0200
  Re: [PATCH v2 01/16] dmaengine: bcm-sba-raid: Minor improvments in comments Anup Patel <anup.patel@broadcom.com> - 2017-08-18 07:00 +0200

csiph-web