Re: [PATCH] PCI: Allow PCI express root ports to find themselves

From	Michael Ellerman <mpe@ellerman.id.au>
Newsgroups	linux.kernel
Subject	Re: [PATCH] PCI: Allow PCI express root ports to find themselves
Date	2017-08-18 06:40 +0200
Message-ID	<ufHeF-6JQ-13@gated-at.bofh.it> (permalink)
References	<ufiJj-6RK-1@gated-at.bofh.it> <ufqQy-40w-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Thierry Reding <thierry.reding@gmail.com> writes:

> From: Thierry Reding <treding@nvidia.com>
>
> If the pci_find_pcie_root_port() function is called on a root port
> itself, return the root port rather than NULL.
>
> This effectively reverts commit 0e405232871d6 ("PCI: fix oops when
> try to find Root Port for a PCI device") which added an extra check
> that would now be redundant.
>
> Fixes: a99b646afa8a ("PCI: Disable PCIe Relaxed Ordering if unsupported")
> Fixes: c56d4450eb68 ("PCI: Turn off Request Attributes to avoid Chelsio T5 Completion erratum")
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
> This applies on top of and was tested on next-20170817.
>
> Michael, it'd be great if you could test this one again to clarify
> whether or not the fix that's already in Linus' tree is still needed, or
> whether it's indeed obsoleted by this patch.

This works fine for me, applied on top of Linus' tree (d33a2a914319).

cheers

Thread

[PATCH net] PCI: fix the return value for the pci_find_pcie_root_port() Ding Tianhong <dingtianhong@huawei.com> - 2017-08-17 04:30 +0200
  Re: [PATCH net] PCI: fix the return value for the  pci_find_pcie_root_port() David Miller <davem@davemloft.net> - 2017-08-17 04:50 +0200
  Re: [PATCH net] PCI: fix the return value for the  pci_find_pcie_root_port() Thierry Reding <thierry.reding@gmail.com> - 2017-08-17 13:00 +0200
    Re: [PATCH net] PCI: fix the return value for the  pci_find_pcie_root_port() Ding Tianhong <dingtianhong@huawei.com> - 2017-08-17 14:50 +0200
      Re: [PATCH net] PCI: fix the return value for the  pci_find_pcie_root_port() Thierry Reding <thierry.reding@gmail.com> - 2017-08-17 15:40 +0200
        Re: [PATCH net] PCI: fix the return value for the  pci_find_pcie_root_port() Ding Tianhong <dingtianhong@huawei.com> - 2017-08-17 15:50 +0200
  [PATCH] PCI: Allow PCI express root ports to find themselves Thierry Reding <thierry.reding@gmail.com> - 2017-08-17 13:10 +0200
    Re: [PATCH] PCI: Allow PCI express root ports to find themselves Bjorn Helgaas <helgaas@kernel.org> - 2017-08-17 19:00 +0200
    Re: [PATCH] PCI: Allow PCI express root ports to find themselves Shawn Lin <shawn.lin@rock-chips.com> - 2017-08-18 03:40 +0200
    Re: [PATCH] PCI: Allow PCI express root ports to find themselves Michael Ellerman <mpe@ellerman.id.au> - 2017-08-18 06:40 +0200
    Re: [PATCH] PCI: Allow PCI express root ports to find themselves David Miller <davem@davemloft.net> - 2017-08-19 01:20 +0200

csiph-web