Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1714519
| From | "Gustavo A. R. Silva" <gustavo@embeddedor.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH] vmci: fix duplicated code for different branches |
| Date | 2017-08-18 03:50 +0200 |
| Message-ID | <ufEAa-4Kd-3@gated-at.bofh.it> (permalink) |
| Organization | linux.* mail to news gateway |
Refactor code in order to avoid identical code for different branches. This issue was detected with the help of Coccinelle. Addresses-Coverity-ID: 1226762 Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> --- This issue was reported by Coverity and it was tested by compilation only. drivers/misc/vmw_vmci/vmci_queue_pair.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/misc/vmw_vmci/vmci_queue_pair.c b/drivers/misc/vmw_vmci/vmci_queue_pair.c index 06c4974..8af5c26 100644 --- a/drivers/misc/vmw_vmci/vmci_queue_pair.c +++ b/drivers/misc/vmw_vmci/vmci_queue_pair.c @@ -2235,14 +2235,8 @@ int vmci_qp_broker_detach(struct vmci_handle handle, struct vmci_ctx *context) handle.context, handle.resource, result); - if (entry->vmci_page_files) - qp_host_unregister_user_memory(entry->produce_q, - entry-> - consume_q); - else - qp_host_unregister_user_memory(entry->produce_q, - entry-> - consume_q); + qp_host_unregister_user_memory(entry->produce_q, + entry->consume_q); } -- 2.5.0
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
[PATCH] vmci: fix duplicated code for different branches "Gustavo A. R. Silva" <gustavo@embeddedor.com> - 2017-08-18 03:50 +0200
csiph-web