Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1714483

Re: [PATCH v2] blktrace: Fix potentail deadlock between delete & sysfs ops

From Steven Rostedt <rostedt@goodmis.org>
Newsgroups linux.kernel
Subject Re: [PATCH v2] blktrace: Fix potentail deadlock between delete & sysfs ops
Date 2017-08-18 01:30 +0200
Message-ID <ufCoG-3ms-17@gated-at.bofh.it> (permalink)
References (2 earlier) <ufvQd-7mK-5@gated-at.bofh.it> <ufAmS-21P-33@gated-at.bofh.it> <ufAwC-26N-141@gated-at.bofh.it> <ufBiW-2Hx-27@gated-at.bofh.it> <ufBiW-2Hx-25@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Thu, 17 Aug 2017 18:18:18 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:

> On Thu, 17 Aug 2017 18:13:20 -0400
> Steven Rostedt <rostedt@goodmis.org> wrote:
> 
> > On Thu, 17 Aug 2017 17:27:22 -0400
> > Waiman Long <longman@redhat.com> wrote:
> > 
> >   
> > > It is actually what the patch is trying to do by checking for the
> > > deletion flag in the mutex_trylock loop. Please note that mutex does not
> > > guarantee FIFO ordering of lock acquisition. As a result, cpu1 may call
> > > mutex_lock() and wait for it while cpu2 can set the deletion flag later
> > > and get the mutex first before cpu1. So checking for the deletion flag
> > > before taking the mutex isn't enough.    
> > 
> > Yeah, I figured that out already (crossed emails). BTW, how did you
> > trigger this warning. I'm playing around with adding loop devices,
> > volume groups, and logical volumes, and reading the trace files
> > created in the sysfs directory, then removing those items, but it's
> > not triggering the "delete" path. What operation deletes the partition?  
> 
> I'm guessing that deleting an actual partition may work (unfortunately,
> my test box has no partition to delete ;-) I'll find another box to
> test on.
>

OK, deleting a partition doesn't trigger the lockdep splat. But I also
added a printk in the BLKPG_DEL_PARTITION case switch, which also
doesn't print. What command do I need to do to trigger that path?

Thanks,

-- Steve

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2] blktrace: Fix potentail deadlock between delete & sysfs ops Waiman Long <longman@redhat.com> - 2017-08-16 22:50 +0200
  Re: [PATCH v2] blktrace: Fix potentail deadlock between delete &  sysfs ops Steven Rostedt <rostedt@goodmis.org> - 2017-08-17 15:40 +0200
    Re: [PATCH v2] blktrace: Fix potentail deadlock between delete &  sysfs ops Waiman Long <longman@redhat.com> - 2017-08-17 18:30 +0200
      Re: [PATCH v2] blktrace: Fix potentail deadlock between delete &  sysfs ops Steven Rostedt <rostedt@goodmis.org> - 2017-08-17 22:40 +0200
        Re: [PATCH v2] blktrace: Fix potentail deadlock between delete &  sysfs ops Bart Van Assche <Bart.VanAssche@wdc.com> - 2017-08-17 22:50 +0200
          Re: [PATCH v2] blktrace: Fix potentail deadlock between delete &  sysfs ops Steven Rostedt <rostedt@goodmis.org> - 2017-08-17 23:00 +0200
      Re: [PATCH v2] blktrace: Fix potentail deadlock between delete &  sysfs ops Steven Rostedt <rostedt@goodmis.org> - 2017-08-17 23:20 +0200
        Re: [PATCH v2] blktrace: Fix potentail deadlock between delete &  sysfs ops Waiman Long <longman@redhat.com> - 2017-08-17 23:30 +0200
          Re: [PATCH v2] blktrace: Fix potentail deadlock between delete &  sysfs ops Steven Rostedt <rostedt@goodmis.org> - 2017-08-18 00:20 +0200
            Re: [PATCH v2] blktrace: Fix potentail deadlock between delete &  sysfs ops Steven Rostedt <rostedt@goodmis.org> - 2017-08-18 01:30 +0200
              Re: [PATCH v2] blktrace: Fix potentail deadlock between delete &  sysfs ops Waiman Long <longman@redhat.com> - 2017-08-18 15:50 +0200
          Re: [PATCH v2] blktrace: Fix potentail deadlock between delete &  sysfs ops Steven Rostedt <rostedt@goodmis.org> - 2017-08-18 00:20 +0200
        Re: [PATCH v2] blktrace: Fix potentail deadlock between delete &  sysfs ops Steven Rostedt <rostedt@goodmis.org> - 2017-08-17 23:40 +0200
          Re: [PATCH v2] blktrace: Fix potentail deadlock between delete &  sysfs ops Waiman Long <longman@redhat.com> - 2017-08-18 16:00 +0200
            Re: [PATCH v2] blktrace: Fix potentail deadlock between delete &  sysfs ops Bart Van Assche <Bart.VanAssche@wdc.com> - 2017-08-18 18:30 +0200
              Re: [PATCH v2] blktrace: Fix potentail deadlock between delete &  sysfs ops Waiman Long <longman@redhat.com> - 2017-08-18 19:30 +0200
              Re: [PATCH v2] blktrace: Fix potentail deadlock between delete &  sysfs ops Steven Rostedt <rostedt@goodmis.org> - 2017-08-18 19:30 +0200

csiph-web