Re: [PATCH] ASoC: mediatek: Correct the interrupt property

From	Rob Herring <robh@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] ASoC: mediatek: Correct the interrupt property
Date	2017-08-17 23:30 +0200
Message-ID	<ufAwx-26N-1@gated-at.bofh.it> (permalink)
References	<ueF5f-7dZ-15@gated-at.bofh.it> <ueIFQ-RA-7@gated-at.bofh.it> <ueKxX-1YZ-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Aug 15, 2017 at 09:51:40PM +0800, Ryder Lee wrote:
> On Tue, 2017-08-15 at 12:53 +0100, Mark Brown wrote:
> > On Tue, Aug 15, 2017 at 04:07:02PM +0800, Ryder Lee wrote:
> > 
> > > This patch update interrupt property since we only use ASYS IRQ
> > > in the driver, and this may confuse people.
> > 
> > > -		interrupts = <GIC_SPI 104 IRQ_TYPE_LEVEL_LOW>,
> > > -			     <GIC_SPI 132 IRQ_TYPE_LEVEL_LOW>;
> > > +		interrupts = <GIC_SPI 132 IRQ_TYPE_LEVEL_LOW>;
> > 
> > What harm does having the extra information in the bindings do?  If it's
> > possible there might be a use for the extra interrupt it seems better to
> > have people describe it.

Agreed. It should describe interrupts the h/w has, not what the driver 
(currently) uses.
> 
> Yes you're right. The current driver get IRQ number by index "0" but
> actually it should be "1" (GIC 132). Perhaps we can switch to use the
> platform_get_irq_byname() and add interrupt-name in DT so that binding
> can be agnostic of the IRQ order. 

The binding is wrong already in that it says a single interrrupt. The 
example has 2 though. Add the 2nd interrupt and define the order such 
that you don't break the current driver. Probably that means ASYS is 
first.

Rob

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] ASoC: mediatek: Correct the interrupt property Ryder Lee <ryder.lee@mediatek.com> - 2017-08-15 10:10 +0200
  Re: [PATCH] ASoC: mediatek: Correct the interrupt property Mark Brown <broonie@kernel.org> - 2017-08-15 14:00 +0200
    Re: [PATCH] ASoC: mediatek: Correct the interrupt property Ryder Lee <ryder.lee@mediatek.com> - 2017-08-15 16:00 +0200
      Re: [PATCH] ASoC: mediatek: Correct the interrupt property Mark Brown <broonie@kernel.org> - 2017-08-15 16:00 +0200
      Re: [PATCH] ASoC: mediatek: Correct the interrupt property Rob Herring <robh@kernel.org> - 2017-08-17 23:30 +0200

csiph-web