Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1713108

Re: [PATCH v5 4/5] fs, xfs: introduce MAP_DIRECT for creating block-map-atomic file ranges

From Dan Williams <dan.j.williams@intel.com>
Newsgroups linux.kernel
Subject Re: [PATCH v5 4/5] fs, xfs: introduce MAP_DIRECT for creating block-map-atomic file ranges
Date 2017-08-16 18:40 +0200
Message-ID <uf9wl-VL-11@gated-at.bofh.it> (permalink)
References <uf1p7-4gv-3@gated-at.bofh.it> <uf1p9-4gv-45@gated-at.bofh.it> <uf4wG-6mG-15@gated-at.bofh.it> <uf9mG-Sp-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Wed, Aug 16, 2017 at 9:29 AM, Dan Williams <dan.j.williams@intel.com> wrote:
> On Wed, Aug 16, 2017 at 4:12 AM, Kirill A. Shutemov
> <kirill@shutemov.name> wrote:
>> On Wed, Aug 16, 2017 at 12:44:28AM -0700, Dan Williams wrote:
>>> @@ -1411,6 +1422,9 @@ unsigned long do_mmap(struct file *file, unsigned long addr,
>>>
>>>                       /* fall through */
>>>               case MAP_PRIVATE:
>>> +                     if ((flags & (MAP_PRIVATE|MAP_DIRECT))
>>> +                                     == (MAP_PRIVATE|MAP_DIRECT))
>>> +                             return -EINVAL;
>>
>> We've already checked for MAP_PRIVATE in this codepath. Simple (flags &
>> MAP_DIRECT) would be enough.
>
> True, willl fix.

Actually, no, because of the fallthrough we need to check MAP_SHARED
or MAP_PRIVATE along with MAP_DIRECT.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v5 0/5] MAP_DIRECT and block-map-atomic files Dan Williams <dan.j.williams@intel.com> - 2017-08-16 10:00 +0200
  [PATCH v5 2/5] fs, xfs: introduce S_IOMAP_SEALED Dan Williams <dan.j.williams@intel.com> - 2017-08-16 10:00 +0200
  [PATCH v5 3/5] mm: introduce mmap3 for safely defining new mmap  flags Dan Williams <dan.j.williams@intel.com> - 2017-08-16 10:00 +0200
    Re: [PATCH v5 3/5] mm: introduce mmap3 for safely defining new mmap  flags "Kirill A. Shutemov" <kirill@shutemov.name> - 2017-08-16 13:20 +0200
      Re: [PATCH v5 3/5] mm: introduce mmap3 for safely defining new mmap flags Dan Williams <dan.j.williams@intel.com> - 2017-08-16 18:40 +0200
        Re: [PATCH v5 3/5] mm: introduce mmap3 for safely defining new mmap  flags "Kirill A. Shutemov" <kirill@shutemov.name> - 2017-08-16 18:50 +0200
          Re: [PATCH v5 3/5] mm: introduce mmap3 for safely defining new mmap flags Dan Williams <dan.j.williams@intel.com> - 2017-08-16 19:00 +0200
  [PATCH v5 4/5] fs,  xfs: introduce MAP_DIRECT for creating block-map-atomic file ranges Dan Williams <dan.j.williams@intel.com> - 2017-08-16 10:00 +0200
    Re: [PATCH v5 4/5] fs, xfs: introduce MAP_DIRECT for creating  block-map-atomic file ranges "Kirill A. Shutemov" <kirill@shutemov.name> - 2017-08-16 13:20 +0200
      Re: [PATCH v5 4/5] fs, xfs: introduce MAP_DIRECT for creating  block-map-atomic file ranges Dan Williams <dan.j.williams@intel.com> - 2017-08-16 18:30 +0200
        Re: [PATCH v5 4/5] fs, xfs: introduce MAP_DIRECT for creating  block-map-atomic file ranges Dan Williams <dan.j.williams@intel.com> - 2017-08-16 18:40 +0200
    Re: [PATCH v5 4/5] fs, xfs: introduce MAP_DIRECT for creating  block-map-atomic file ranges Dan Williams <dan.j.williams@intel.com> - 2017-08-16 19:30 +0200
  Re: [PATCH v5 0/5] MAP_DIRECT and block-map-atomic files Dan Williams <dan.j.williams@intel.com> - 2017-08-17 01:50 +0200

csiph-web