Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1713033

RE: [PATCH 1/2] x86/intel_rdt/mbm: Fix MBM overflow handler during hot cpu

From Thomas Gleixner <tglx@linutronix.de>
Newsgroups linux.kernel
Subject RE: [PATCH 1/2] x86/intel_rdt/mbm: Fix MBM overflow handler during hot cpu
Date 2017-08-16 17:00 +0200
Message-ID <uf7XB-8ld-35@gated-at.bofh.it> (permalink)
References <ueUQF-4Q-3@gated-at.bofh.it> <ueUQF-4Q-1@gated-at.bofh.it> <uf2Od-5hi-9@gated-at.bofh.it> <uf7XA-8ld-15@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Wed, 16 Aug 2017, Luck, Tony wrote:
> > You could alternatively use flush and make the worker code schedule the
> > work on a still online CPU in the domain instead of blindly rescheduling it
> > on the same CPU.
> 
> We looked at that when you suggested flush. The problem is that we have
> already deleted the current cpu from the bitmask for the domain. So the
> worker code doesn't know which domain it is running on, so can't pick
> another.
> 
> If we try to do the flush before dropping the cpu from the bitmask, then
> the worker code doesn't have any reason to pick a different CPU.
> 
> Is there is some cheap "I'm running on a CPU that is in the process of going
> offline" test that we could make in the worker code?

Don't think so. It was just a thought, but the code as provided is fine and
merged as is.

Thanks,

	tglx

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 1/2] x86/intel_rdt/mbm: Fix MBM overflow handler during hot cpu Vikas Shivappa <vikas.shivappa@linux.intel.com> - 2017-08-16 03:00 +0200
  Re: [PATCH 1/2] x86/intel_rdt/mbm: Fix MBM overflow handler during  hot cpu Thomas Gleixner <tglx@linutronix.de> - 2017-08-16 11:30 +0200
    RE: [PATCH 1/2] x86/intel_rdt/mbm: Fix MBM overflow handler during  hot cpu "Luck, Tony" <tony.luck@intel.com> - 2017-08-16 17:00 +0200
      RE: [PATCH 1/2] x86/intel_rdt/mbm: Fix MBM overflow handler during  hot cpu Thomas Gleixner <tglx@linutronix.de> - 2017-08-16 17:00 +0200
  [tip:x86/cache] x86/intel_rdt/mbm: Fix MBM overflow handler during  CPU hotplug tip-bot for Vikas Shivappa <tipbot@zytor.com> - 2017-08-16 12:20 +0200

csiph-web