Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1712956
| From | Guenter Roeck <linux@roeck-us.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v4 1/3] dt-bindings: i2c: Document the IBM CCF power supply version 1 |
| Date | 2017-08-16 15:50 +0200 |
| Message-ID | <uf6RQ-7G2-9@gated-at.bofh.it> (permalink) |
| References | <ueR6q-6aN-23@gated-at.bofh.it> <ueR6r-6aN-51@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 08/15/2017 01:52 PM, Eddie James wrote:
> From: "Edward A. James" <eajames@us.ibm.com>
>
> Signed-off-by: Edward A. James <eajames@us.ibm.com>
> ---
> .../devicetree/bindings/i2c/ibm,cffps1.txt | 21 +++++++++++++++++++++
Sorry, just noticed. Sorry for the piecemeal review :-(.
The i2c directory is used for i2c controllers, not for other i2c devices.
Please move to hwmon (and drop i2c from the subject).
Thanks,
Guenter
> 1 file changed, 21 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/i2c/ibm,cffps1.txt
>
> diff --git a/Documentation/devicetree/bindings/i2c/ibm,cffps1.txt b/Documentation/devicetree/bindings/i2c/ibm,cffps1.txt
> new file mode 100644
> index 0000000..f68a0a6
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/i2c/ibm,cffps1.txt
> @@ -0,0 +1,21 @@
> +Device-tree bindings for IBM Common Form Factor Power Supply Version 1
> +----------------------------------------------------------------------
> +
> +Required properties:
> + - compatible = "ibm,cffps1";
> + - reg = < I2C bus address >; : Address of the power supply on the
> + I2C bus.
> +
> +Example:
> +
> + i2c-bus@100 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + #interrupt-cells = <1>;
> + < more properties >
> +
> + power-supply@68 {
> + compatible = "ibm,cffps1";
> + reg = <0x68>;
> + };
> + };
>
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH v4 0/3] hwmon: (pmbus): Add IBM Common Form Factor (CFF) power supply driver Eddie James <eajames@linux.vnet.ibm.com> - 2017-08-15 23:00 +0200
[PATCH v4 3/3] Documentation: hwmon: Document the IBM CFF power supply Eddie James <eajames@linux.vnet.ibm.com> - 2017-08-15 23:00 +0200
[PATCH v4 2/3] hwmon: (pmbus): Add IBM Common Form Factor (CFF) power supply driver Eddie James <eajames@linux.vnet.ibm.com> - 2017-08-15 23:00 +0200
[PATCH v4 1/3] dt-bindings: i2c: Document the IBM CCF power supply version 1 Eddie James <eajames@linux.vnet.ibm.com> - 2017-08-15 23:00 +0200
Re: [PATCH v4 1/3] dt-bindings: i2c: Document the IBM CCF power supply version 1 Guenter Roeck <linux@roeck-us.net> - 2017-08-16 15:50 +0200
csiph-web