Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1712843

Re: [PATCH 1/2] zpool: Delete an error message for a failed memory allocation in zpool_create_pool()

From Dan Streetman <ddstreet@ieee.org>
Newsgroups linux.kernel
Subject Re: [PATCH 1/2] zpool: Delete an error message for a failed memory allocation in zpool_create_pool()
Date 2017-08-16 13:20 +0200
Message-ID <uf4wG-6mG-9@gated-at.bofh.it> (permalink)
References <uelzz-3tE-1@gated-at.bofh.it> <uelzA-3tE-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Mon, Aug 14, 2017 at 7:15 AM, SF Markus Elfring
<elfring@users.sourceforge.net> wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Mon, 14 Aug 2017 12:57:16 +0200
>
> Omit an extra message for a memory allocation failure in this function.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>

Acked-by: Dan Streetman <ddstreet@ieee.org>

> ---
>  mm/zpool.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/mm/zpool.c b/mm/zpool.c
> index fd3ff719c32c..fe1943f7d844 100644
> --- a/mm/zpool.c
> +++ b/mm/zpool.c
> @@ -172,7 +172,6 @@ struct zpool *zpool_create_pool(const char *type, const char *name, gfp_t gfp,
>
>         zpool = kmalloc(sizeof(*zpool), gfp);
>         if (!zpool) {
> -               pr_err("couldn't create zpool - out of memory\n");
>                 zpool_put_driver(driver);
>                 return NULL;
>         }
> --
> 2.14.0
>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 0/2] zpool: Adjustments for zpool_create_pool() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-14 13:20 +0200
  [PATCH 1/2] zpool: Delete an error message for a failed memory  allocation in zpool_create_pool() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-14 13:20 +0200
    Re: [PATCH 1/2] zpool: Delete an error message for a failed memory  allocation in zpool_create_pool() Dan Streetman <ddstreet@ieee.org> - 2017-08-16 13:20 +0200
  [PATCH 2/2] zpool: Use common error handling code in  zpool_create_pool() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-14 13:20 +0200
    Re: [PATCH 2/2] zpool: Use common error handling code in zpool_create_pool() Dan Streetman <ddstreet@ieee.org> - 2017-08-16 13:30 +0200

csiph-web