Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1712755
| From | Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 1/2] pstore: Make default pstorefs root dir perms 0750 |
| Date | 2017-08-16 10:10 +0200 |
| Message-ID | <uf1yN-4Ab-5@gated-at.bofh.it> (permalink) |
| References | <ud2pk-2qz-5@gated-at.bofh.it> <ud2pl-2qz-29@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Hello,
On (08/10/17 13:36), Kees Cook wrote:
> Currently only DMESG and CONSOLE record types are protected, and it isn't
> obvious that they are using a capability check. Instead switch to explicit
> root directory mode of 0750 to keep files private by default. This will
> allow the removal of the capability check, which was non-obvious and
> forces a process to have possibly too much privilege
it's CAP_SYSLOG, isn't it? is it too much? does chgrp require less privileges?
-ss
> when simple post-boot chgrp for readers would be possible without it.
>
> Signed-off-by: Kees Cook <keescook@chromium.org>
> ---
> fs/pstore/inode.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/pstore/inode.c b/fs/pstore/inode.c
> index fefd22611cf6..f1e88b695090 100644
> --- a/fs/pstore/inode.c
> +++ b/fs/pstore/inode.c
> @@ -471,7 +471,7 @@ static int pstore_fill_super(struct super_block *sb, void *data, int silent)
>
> inode = pstore_get_inode(sb);
> if (inode) {
> - inode->i_mode = S_IFDIR | 0755;
> + inode->i_mode = S_IFDIR | 0750;
> inode->i_op = &pstore_dir_inode_operations;
> inode->i_fop = &simple_dir_operations;
> inc_nlink(inode);
> --
> 2.7.4
>
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
Re: [PATCH 1/2] pstore: Make default pstorefs root dir perms 0750 Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2017-08-16 10:10 +0200
csiph-web