Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1711462

RE: [[PATCH v1] 24/37] [CIFS] SMBD: Support for SMBD keep alive protocol

From Tom Talpey <ttalpey@microsoft.com>
Newsgroups linux.kernel
Subject RE: [[PATCH v1] 24/37] [CIFS] SMBD: Support for SMBD keep alive protocol
Date 2017-08-14 23:10 +0200
Message-ID <ueuMy-IV-23@gated-at.bofh.it> (permalink)
References <ua8hz-6jk-3@gated-at.bofh.it> <ua8hA-6jk-27@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


> -----Original Message-----
> From: linux-cifs-owner@vger.kernel.org [mailto:linux-cifs-
> owner@vger.kernel.org] On Behalf Of Long Li
> Sent: Wednesday, August 2, 2017 4:11 PM
> To: Steve French <sfrench@samba.org>; linux-cifs@vger.kernel.org; samba-
> technical@lists.samba.org; linux-kernel@vger.kernel.org
> Cc: Long Li <longli@microsoft.com>
> Subject: [[PATCH v1] 24/37] [CIFS] SMBD: Support for SMBD keep alive
> protocol
> 
> SMBD uses a keep alive protocol to help peers detect if the remote is dead.
> When peer request keep alive, the transport needs to respond accordingly.

The keepalive exchange is also used to replenish credits in certain
pathological conditions.

> +               // send an emtpy response right away if requested
> +               if (le16_to_cpu(data_transfer->flags) |
> +                               le16_to_cpu(SMB_DIRECT_RESPONSE_REQUESTED)) {
> +                       info->keep_alive_requested = KEEP_ALIVE_PENDING;
> +               }

This is clearly a typo, the condition is always true. "&"??

Tom.

Back to linux.kernel | Previous | NextNext in thread | Find similar | Unroll thread


Thread

RE: [[PATCH v1] 24/37] [CIFS] SMBD: Support for SMBD keep alive  protocol Tom Talpey <ttalpey@microsoft.com> - 2017-08-14 23:10 +0200
  RE: [[PATCH v1] 24/37] [CIFS] SMBD: Support for SMBD keep alive  protocol Long Li <longli@microsoft.com> - 2017-08-15 01:30 +0200

csiph-web