Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1711136

Re: [PATCH] x86/mm: Fix personality(ADDR_NO_RANDOMIZE)

Show all headers | View raw

On Mon, Aug 14, 2017 at 06:57:19PM +0300, Kirill A. Shutemov wrote:
> In v4.12, during rework of infrastructure around mmap_base, disable-ASLR
> personality flag got accidentally broken.
> 
> Let's make it work again.
> 
> Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> Fixes: 1b028f784e8c ("x86/mm: Introduce mmap_compat_base() for 32-bit mmap()")
> Cc: stable <stable@vger.kernel.org> [4.12+]
> ---
>  arch/x86/mm/mmap.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/x86/mm/mmap.c b/arch/x86/mm/mmap.c
> index 229d04a83f85..779bdbe5e424 100644
> --- a/arch/x86/mm/mmap.c
> +++ b/arch/x86/mm/mmap.c
> @@ -127,6 +127,8 @@ static unsigned long mmap_legacy_base(unsigned long rnd,
>  static void arch_pick_mmap_base(unsigned long *base, unsigned long *legacy_base,
>  		unsigned long random_factor, unsigned long task_size)
>  {
> +	if (!(current->flags & PF_RANDOMIZE))
> +		random_factor = 0;
>  	*legacy_base = mmap_legacy_base(random_factor, task_size);
>  	if (mmap_is_legacy())
>  		*base = *legacy_base;

Didn't Oleg's patch does the same?

https://patchwork.kernel.org/patch/9832697/

for some reason it's not yet merged.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] x86/mm: Fix personality(ADDR_NO_RANDOMIZE) "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> - 2017-08-14 18:00 +0200
  Re: [PATCH] x86/mm: Fix personality(ADDR_NO_RANDOMIZE) Cyrill Gorcunov <gorcunov@gmail.com> - 2017-08-14 18:20 +0200
    Re: [PATCH] x86/mm: Fix personality(ADDR_NO_RANDOMIZE) "Kirill A. Shutemov" <kirill@shutemov.name> - 2017-08-14 18:30 +0200
    Re: [PATCH] x86/mm: Fix personality(ADDR_NO_RANDOMIZE) "Kirill A. Shutemov" <kirill@shutemov.name> - 2017-08-14 18:30 +0200
    Re: [PATCH] x86/mm: Fix personality(ADDR_NO_RANDOMIZE) Oleg Nesterov <oleg@redhat.com> - 2017-08-14 18:30 +0200
      Re: [PATCH] x86/mm: Fix personality(ADDR_NO_RANDOMIZE) Cyrill Gorcunov <gorcunov@gmail.com> - 2017-08-14 18:40 +0200

csiph-web