Re: [PATCH] staging: lustre: lnet: fix incorrect arguments order calling lstcon_session_new

From	James Simmons <jsimmons@infradead.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] staging: lustre: lnet: fix incorrect arguments order calling lstcon_session_new
Date	2017-08-14 17:00 +0200
Message-ID	<uep0v-5p7-33@gated-at.bofh.it> (permalink)
References	<u501k-2Gh-33@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


> From: Colin Ian King <colin.king@canonical.com>
> 
> The arguments args->lstio_ses_force and args->lstio_ses_timeout are
> in the incorrect order. Fix this by swapping them around.
> 
> Detected by CoverityScan, CID#1226833 ("Arguments in wrong order")

This patch is being tracked under 

https://jira.hpdd.intel.com/browse/LU-9869

I pushed the patch into our main test framework which passed testing.
Just waiting for reviews. Thank you.
 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  drivers/staging/lustre/lnet/selftest/conctl.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/lustre/lnet/selftest/conctl.c b/drivers/staging/lustre/lnet/selftest/conctl.c
> index 6ca7192b03b7..043eafb5ea40 100644
> --- a/drivers/staging/lustre/lnet/selftest/conctl.c
> +++ b/drivers/staging/lustre/lnet/selftest/conctl.c
> @@ -69,8 +69,8 @@ lst_session_new_ioctl(struct lstio_session_new_args *args)
>  	rc = lstcon_session_new(name,
>  				args->lstio_ses_key,
>  				args->lstio_ses_feats,
> -				args->lstio_ses_force,
>  				args->lstio_ses_timeout,
> +				args->lstio_ses_force,
>  				args->lstio_ses_idp);
>  
>  	LIBCFS_FREE(name, args->lstio_ses_nmlen + 1);
> -- 
> 2.11.0
> 
>

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] staging: lustre: lnet: fix incorrect arguments order  calling lstcon_session_new James Simmons <jsimmons@infradead.org> - 2017-08-14 17:00 +0200

csiph-web