Re: [PATCH v3 1/3] irq/irq_sim: add a simple interrupt simulator framework

From	Thomas Gleixner <tglx@linutronix.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 1/3] irq/irq_sim: add a simple interrupt simulator framework
Date	2017-08-14 16:50 +0200
Message-ID	<ueoQN-5lI-1@gated-at.bofh.it> (permalink)
References	<uelJf-3wX-5@gated-at.bofh.it> <uelJf-3wX-11@gated-at.bofh.it> <ueni1-4zq-5@gated-at.bofh.it> <ueoQN-5lI-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, 14 Aug 2017, Bartosz Golaszewski wrote:
> 2017-08-14 15:06 GMT+02:00 Thomas Gleixner <tglx@linutronix.de>:
> > On Mon, 14 Aug 2017, Bartosz Golaszewski wrote:
> >
> >> Implement a simple, irq_work-based framework for simulating
> >> interrupts. Currently the API exposes routines for initializing and
> >> deinitializing the simulator object, enqueueing the interrupts and
> >> retrieving the allocated interrupt numbers based on the offset of the
> >> dummy interrupt in the simulator struct.
> >>
> >> Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
> >> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> >> ---
> >>  include/linux/irq_sim.h |  44 ++++++++++++++++++
> >>  init/Kconfig            |   4 ++
> >>  kernel/Makefile         |   1 +
> >>  kernel/irq_sim.c        | 121 ++++++++++++++++++++++++++++++++++++++++++++++++
> >
> > Please move this to kernel/irq/ ... and the config option to kernel/irq/Kconfig.
> >
> > Thanks,
> >
> >         tglx
> >
> >
> 
> How about moving irq_work.c there too?

We could, but irq_work is not really part of the interrupt subsystem, while
your interrupt simulator definitely is.

Thanks,

	tglx

Thread

[PATCH v3 0/3] simulated interrupts Bartosz Golaszewski <brgl@bgdev.pl> - 2017-08-14 13:30 +0200
  [PATCH v3 3/3] gpio: mockup: use irq_sim Bartosz Golaszewski <brgl@bgdev.pl> - 2017-08-14 13:30 +0200
    Re: [PATCH v3 3/3] gpio: mockup: use irq_sim Linus Walleij <linus.walleij@linaro.org> - 2017-08-21 00:20 +0200
  [PATCH v3 1/3] irq/irq_sim: add a simple interrupt simulator framework Bartosz Golaszewski <brgl@bgdev.pl> - 2017-08-14 13:30 +0200
    Re: [PATCH v3 1/3] irq/irq_sim: add a simple interrupt simulator  framework Thomas Gleixner <tglx@linutronix.de> - 2017-08-14 15:10 +0200
      Re: [PATCH v3 1/3] irq/irq_sim: add a simple interrupt simulator  framework Thomas Gleixner <tglx@linutronix.de> - 2017-08-14 16:50 +0200
        Re: [PATCH v3 1/3] irq/irq_sim: add a simple interrupt simulator framework Bartosz Golaszewski <brgl@bgdev.pl> - 2017-08-14 16:50 +0200
      Re: [PATCH v3 1/3] irq/irq_sim: add a simple interrupt simulator framework Bartosz Golaszewski <brgl@bgdev.pl> - 2017-08-14 16:50 +0200
  [PATCH v3 2/3] irq/irq_sim: add a devres variant of irq_sim_init() Bartosz Golaszewski <brgl@bgdev.pl> - 2017-08-14 13:30 +0200

csiph-web