Re: [v6 02/15] x86/mm: setting fields in deferred pages

From	Pasha Tatashin <pasha.tatashin@oracle.com>
Newsgroups	linux.kernel
Subject	Re: [v6 02/15] x86/mm: setting fields in deferred pages
Date	2017-08-14 15:40 +0200
Message-ID	<uenL4-4Jh-15@gated-at.bofh.it> (permalink)
References	<ubX8m-5vB-5@gated-at.bofh.it> <ubX8m-5vB-23@gated-at.bofh.it> <ude78-1CC-7@gated-at.bofh.it> <udkme-5jx-23@gated-at.bofh.it> <uem2B-3DE-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


On 08/14/2017 07:43 AM, Michal Hocko wrote:
>> register_page_bootmem_info
>>   register_page_bootmem_info_node
>>    get_page_bootmem
>>     .. setting fields here ..
>>     such as: page->freelist = (void *)type;
>>
>> free_all_bootmem()
>>   free_low_memory_core_early()
>>    for_each_reserved_mem_region()
>>     reserve_bootmem_region()
>>      init_reserved_page() <- Only if this is deferred reserved page
>>       __init_single_pfn()
>>        __init_single_page()
>>            memset(0) <-- Loose the set fields here!
> OK, I have missed that part. Please make it explicit in the changelog.
> It is quite easy to get lost in the deep call chains.

Ok, will update comment.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [v6 02/15] x86/mm: setting fields in deferred pages Michal Hocko <mhocko@kernel.org> - 2017-08-14 13:50 +0200
  Re: [v6 02/15] x86/mm: setting fields in deferred pages Pasha Tatashin <pasha.tatashin@oracle.com> - 2017-08-14 15:40 +0200

csiph-web