Re: [v6 04/15] mm: discard memblock data later

From	Michal Hocko <mhocko@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [v6 04/15] mm: discard memblock data later
Date	2017-08-14 13:40 +0200
Message-ID	<uelSX-3Ag-33@gated-at.bofh.it> (permalink)
References	<ubX8m-5vB-5@gated-at.bofh.it> <ubX8m-5vB-19@gated-at.bofh.it> <udeA9-1Md-3@gated-at.bofh.it> <udntL-7oX-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri 11-08-17 15:00:47, Pasha Tatashin wrote:
> Hi Michal,
> 
> This suggestion won't work, because there are arches without memblock
> support: tile, sh...
> 
> So, I would still need to have:
> 
> #ifdef CONFIG_MEMBLOCK in page_alloc, or define memblock_discard() stubs in
> nobootmem headfile. 

This is the standard way to do this. And it is usually preferred to
proliferate ifdefs in the code.
-- 
Michal Hocko
SUSE Labs

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [v6 04/15] mm: discard memblock data later Michal Hocko <mhocko@kernel.org> - 2017-08-14 13:40 +0200
  Re: [v6 04/15] mm: discard memblock data later Michal Hocko <mhocko@kernel.org> - 2017-08-14 15:50 +0200
  Re: [v6 04/15] mm: discard memblock data later Pasha Tatashin <pasha.tatashin@oracle.com> - 2017-08-14 15:50 +0200

csiph-web