Re: [PATCH] genirq: remove redundant ->handle_irq assignment

Path	csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Thomas Gleixner <tglx@linutronix.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH] genirq: remove redundant ->handle_irq assignment
Date	Mon, 14 Aug 2017 12:10:02 +0200
Message-ID	<uektQ-2Py-15@gated-at.bofh.it> (permalink)
References	<ucKVr-7fS-5@gated-at.bofh.it>
X-Original-To	Masahiro Yamada <yamada.masahiro@socionext.com>
User-Agent	Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version	1.0
Content-Type	text/plain; charset=US-ASCII
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	11
Organization	linux.* mail to news gateway
X-Original-Cc	Jason Cooper <jason@lakedaemon.net>, Marc Zyngier <marc.zyngier@arm.com>, linux-kernel@vger.kernel.org
X-Original-Date	Mon, 14 Aug 2017 12:09:33 +0200 (CEST)
X-Original-Message-ID	<alpine.DEB.2.20.1708141206090.1865@nanos>
X-Original-References	<1502329914-27098-1-git-send-email-yamada.masahiro@socionext.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1710791

Show key headers only | View raw

On Thu, 10 Aug 2017, Masahiro Yamada wrote:

> This function has "desc->handle_irq = handle;" a few lines above.
> The second assignment is redundant.

It's not as redundant as you might think. You missed to read the comment
above that. See also commit 1e12c4a9393b7.

Thanks,

	tglx

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] genirq: remove redundant ->handle_irq assignment Thomas Gleixner <tglx@linutronix.de> - 2017-08-14 12:10 +0200

csiph-web