Re: [PATCH -next] zram: fix compr_data_size stat

Path	csiph.com!news.redatomik.org!aioe.org!bofh.it!news.nic.it!robomod
From	Yisheng Xie <xieyisheng1@huawei.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH -next] zram: fix compr_data_size stat
Date	Mon, 14 Aug 2017 11:30:02 +0200
Message-ID	<uejR8-2n2-5@gated-at.bofh.it> (permalink)
References	<ud6Mh-5kY-11@gated-at.bofh.it> <ueiBH-1HF-5@gated-at.bofh.it>
X-Original-To	Minchan Kim <minchan@kernel.org>
User-Agent	Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0
MIME-Version	1.0
Content-Type	text/plain; charset="windows-1252"
Content-Transfer-Encoding	7bit
X-Originating-IP	[10.177.29.40]
X-Cfilter-Loop	Reflected
X-Mirapoint-Virus-Rapid-Raw	score=unknown(0), refid=str=0001.0A020205.59916C93.000D,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32
X-Mirapoint-Loop-ID	e8ac5fd6ce0bdf4039e5c348404b9255
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	50
Organization	linux.* mail to news gateway
X-Original-Cc	<akpm@linux-foundation.org>, <ngupta@vflare.org>, <sergey.senozhatsky.work@gmail.com>, <linux-kernel@vger.kernel.org>
X-Original-Date	Mon, 14 Aug 2017 17:24:16 +0800
X-Original-Message-ID	<b566a979-8eee-c2aa-5487-af149dfe6da5@huawei.com>
X-Original-References	<1502413832-13560-1-git-send-email-xieyisheng1@huawei.com> <20170814080805.GB26913@bbox>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1710745

Show key headers only | View raw

Hi, Minchan

Thanks for your comment!
On 2017/8/14 16:08, Minchan Kim wrote:
> Hi Yisheng,
> 
> Thanks for the all fixup!
> A minor nitpick below:
> 
> On Fri, Aug 11, 2017 at 09:10:32AM +0800, Yisheng Xie wrote:
>> The compr_data_size is a stat for compressed size of pages stored, which
>> should add comp_len when we compresse a page.
>>
>> Meanwhile fix typos in comment:
>> * ZRAM_SAME means page consists the same element not the entirely zero page
>> * read_from_bdev_async() return 1 to avoid call page_endio() in zram_rw_page()
>>
>> Signed-off-by: Yisheng Xie <xieyisheng1@huawei.com>
>> ---
>>  drivers/block/zram/zram_drv.c | 3 ++-
>>  drivers/block/zram/zram_drv.h | 2 +-
>>  2 files changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c
>> index e27daca..b2b75b1 100644
>> --- a/drivers/block/zram/zram_drv.c
>> +++ b/drivers/block/zram/zram_drv.c
>> @@ -455,7 +455,7 @@ void zram_page_end_io(struct bio *bio)
>>  }
>>  
>>  /*
>> - * Returns 0 if the submission is successful.
>> + * Returns 1 if the submission is successful.
>>   */
>>  static int read_from_bdev_async(struct zram *zram, struct bio_vec *bvec,
>>  			unsigned long entry, struct bio *parent)
>> @@ -1073,6 +1073,7 @@ static int __zram_bvec_write(struct zram *zram, struct bio_vec *bvec,
>>  	}  else {
>>  		zram_set_handle(zram, index, handle);
>>  		zram_set_obj_size(zram, index, comp_len);
>> +		atomic64_add(comp_len, &zram->stats.compr_data_size);
> 
> I want to add the accounting line to zs_unmap_object.

Right, this accounting can be done without slot lock!

You will fold this patch? or should I send another version?

Thanks
Yisheng

Thread

Re: [PATCH -next] zram: fix compr_data_size stat Minchan Kim <minchan@kernel.org> - 2017-08-14 10:10 +0200
  Re: [PATCH -next] zram: fix compr_data_size stat Yisheng Xie <xieyisheng1@huawei.com> - 2017-08-14 11:30 +0200
    Re: [PATCH -next] zram: fix compr_data_size stat Minchan Kim <minchan@kernel.org> - 2017-08-14 11:40 +0200
      Re: [PATCH -next] zram: fix compr_data_size stat Yisheng Xie <xieyisheng1@huawei.com> - 2017-08-14 13:00 +0200

csiph-web