Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1710648

[PATCH 02/10] ASoC: blackfin: constify snd_pcm_ops structures

Show all headers | View raw

snd_pcm_ops are not supposed to change at runtime. All functions
working with snd_pcm_ops provided by <sound/soc.h> work with
const snd_pcm_ops. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 sound/soc/blackfin/bf5xx-ac97-pcm.c | 2 +-
 sound/soc/blackfin/bf5xx-i2s-pcm.c  | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/sound/soc/blackfin/bf5xx-ac97-pcm.c b/sound/soc/blackfin/bf5xx-ac97-pcm.c
index 913e292..8c1d198 100644
--- a/sound/soc/blackfin/bf5xx-ac97-pcm.c
+++ b/sound/soc/blackfin/bf5xx-ac97-pcm.c
@@ -308,7 +308,7 @@ static	int bf5xx_pcm_copy_user(struct snd_pcm_substream *substream,
 }
 #endif
 
-static struct snd_pcm_ops bf5xx_pcm_ac97_ops = {
+static const struct snd_pcm_ops bf5xx_pcm_ac97_ops = {
 	.open		= bf5xx_pcm_open,
 	.ioctl		= snd_pcm_lib_ioctl,
 	.hw_params	= bf5xx_pcm_hw_params,
diff --git a/sound/soc/blackfin/bf5xx-i2s-pcm.c b/sound/soc/blackfin/bf5xx-i2s-pcm.c
index 470d99a..51cae76 100644
--- a/sound/soc/blackfin/bf5xx-i2s-pcm.c
+++ b/sound/soc/blackfin/bf5xx-i2s-pcm.c
@@ -318,7 +318,7 @@ static int bf5xx_pcm_silence(struct snd_pcm_substream *substream,
 	return 0;
 }
 
-static struct snd_pcm_ops bf5xx_pcm_i2s_ops = {
+static const struct snd_pcm_ops bf5xx_pcm_i2s_ops = {
 	.open		= bf5xx_pcm_open,
 	.ioctl		= snd_pcm_lib_ioctl,
 	.hw_params	= bf5xx_pcm_hw_params,
-- 
1.9.1

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 00/10] constify ASoC snd_pcm_ops structures Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-14 08:00 +0200
  [PATCH 10/10] ASoC: txx9: constify snd_pcm_ops structures Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-14 08:00 +0200
    Applied "ASoC: txx9: constify snd_pcm_ops structures" to the asoc tree Mark Brown <broonie@kernel.org> - 2017-08-14 18:50 +0200
  [PATCH 03/10] ASoC: fsl: constify snd_pcm_ops structures Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-14 08:00 +0200
    Applied "ASoC: fsl: constify snd_pcm_ops structures" to the asoc tree Mark Brown <broonie@kernel.org> - 2017-08-14 18:50 +0200
  [PATCH 08/10] ASoC: samsung: constify snd_pcm_ops structures Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-14 08:00 +0200
    Applied "ASoC: samsung: constify snd_pcm_ops structures" to the asoc tree Mark Brown <broonie@kernel.org> - 2017-08-14 18:50 +0200
  [PATCH 09/10] ASoC: sh: constify snd_pcm_ops structures Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-14 08:00 +0200
    Applied "ASoC: sh: constify snd_pcm_ops structures" to the asoc tree Mark Brown <broonie@kernel.org> - 2017-08-14 18:50 +0200
  [PATCH 02/10] ASoC: blackfin: constify snd_pcm_ops structures Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-14 08:00 +0200
    Applied "ASoC: blackfin: constify snd_pcm_ops structures" to the asoc tree Mark Brown <broonie@kernel.org> - 2017-08-14 18:50 +0200
  [PATCH 05/10] ASoC: nuc900: constify snd_pcm_ops structures Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-14 08:00 +0200
    Applied "ASoC: nuc900: constify snd_pcm_ops structures" to the asoc tree Mark Brown <broonie@kernel.org> - 2017-08-14 18:50 +0200
  [PATCH 06/10] ASoC: omap: constify snd_pcm_ops structures Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-14 08:00 +0200
    Applied "ASoC: omap: constify snd_pcm_ops structures" to the asoc tree Mark Brown <broonie@kernel.org> - 2017-08-14 18:50 +0200

csiph-web